Repository navigation
Conversation
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 6, 2026 14:27
|
Label |
…l-conformance The host lanes already share one openshell-conformance build per architecture, but the tmachine conformance rows each cross-built a nextest archive. Add --program to openshell-test-runner to run a prebuilt testkit program in the guest, and have Branch E2E pass the build-conformance artifact to the conformance rows of e2e-suites.yml. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
ci/reuse-prebuilt-conformance/elezar
branch
from
November 6, 2026 17:13
28e47c0 to
4146283
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#5249 builds
openshell-conformanceonce per architecture, but only the host lanes use it. The tmachine conformance rows ine2e-suites.ymlstill cross-build a nextest archive in every job (five builds per run). This runs them with the prebuilt program too.Related Issue
None yet. Follow-up to #5249, part of #3954.
Changes
openshell-test-runnergets--program <path>: it runs a prebuilt testkit program in the guest (ready, thenrun --junit) instead of building a nextest bundle. It conflicts with--package, which only applies to the build.--filter(now repeatable) still applies: with--programit takes parts of test names, as the program does, instead of a nextest filterset. The program's exit codes map to the runner's (1 for a test failure, otherwise an error).e2e-suites.ymlgets aprebuilt-conformanceinput. When set, the conformance rows download theopenshell-conformance-x86_64-unknown-linux-muslartifact and pass it with--program.conformance-integrationneedsbuild-conformanceand sets the input. Release Qualification and Release Dev don't build the program, so their conformance rows are unchanged.TESTING.mddocuments--program.The results layout is unchanged: the program's output is still written to
nextest.logso consumers of the results artifact see one layout.Testing
cargo clippy --all-targets -- -D warningsandcargo testintests/runner(new tests for the program bundle and exit-code mapping)test:e2eon this PR.Checklist