Repository navigation
fix(server): validate provider attachments against latest policy - #5310
Merged
sjenning merged 1 commit intoNov 5, 2026
Merged
Conversation
Signed-off-by: Gordon Sim <gsim@redhat.com>
grs
marked this pull request as ready for review
November 5, 2026 14:15
Collaborator
|
/ok to test b8867df |
sjenning
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate provider credential inspection against the sandbox's latest saved policy, falling back to its creation policy only when no revision exists. Removing an uninspected rule now unblocks otherwise valid provider attachment, while adding one prevents attachment unless the policy explicitly permits uninspected credentials.
Related Issue
Closes #5301
Changes
Release Notes
Testing
Completed before rebasing onto main:
cargo test -p openshell-server --lib provider_attachment— 3 passed.cargo test -p openshell-server --lib attach_sandbox_provider— 12 passed.cargo test -p openshell-server --lib update_config— 37 passed.cargo fmt -p openshell-server -- --check.cargo clippy -p openshell-server --lib --tests -- -D warnings.mise run docs— 0 errors, 3 warnings.After rebasing,
git range-diffconfirmed the patch was unchanged andgit diff --checkpassed. The full test suite has not been verified.Checklist