Repository navigation
docs(testing): note that tmachine runs on macOS - #5304
Merged
Merged
Conversation
tmachine boots guests with the Hypervisor framework on macOS, so the runner does not need KVM there. Signed-off-by: Evan Lezar <elezar@nvidia.com>
alangou
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TESTING.mdsays the test runner needs KVM. tmachine also boots guests on macOS, using the Hypervisor framework, so the runner doesn't need KVM there. Correct the sentence.Related Issue
None. This is a one-sentence documentation correction.
Changes
Release Notes
Testing
The accelerator choice is in
tests/tmachine/src/qemu/vm.rs(hvfon macOS,kvmotherwise). The change is documentation only, and no code checks apply. I ran the runner on an Apple Silicon Mac to confirm that it works there.Checklist