Skip to content

feat(python): add sandbox watches and completion waits - #5170

Closed
maxdubrinsky wants to merge 1 commit into
feat/5165-sandbox-services-logs/maxdubrinskyfrom
feat/5166-sandbox-watch-completion/maxdubrinsky
Closed

maxdubrinsky wants to merge 1 commit into
feat/5165-sandbox-services-logs/maxdubrinskyfrom
feat/5166-sandbox-watch-completion/maxdubrinsky

Conversation

@maxdubrinsky

Copy link
Copy Markdown
Collaborator

Summary

Add sandbox watches that retain event variants, warnings, and resume cursors, plus bounded completion waits that distinguish terminal outcomes and detect same-name replacement. Early stream closure cancels the RPC; reconnect and cursor reset remain explicit.

Stack 3/4; depends on #5169.

Related Issue

Closes #5166

Changes

  • Expose complete watch messages and explicit resume cursors without hidden reconnects.
  • Cancel sync and async watches on iterator closure.
  • Add identity-aware wait_completed with bounded polling and terminal-state handling.

Release Notes

Testing

  • Clean-checkout Python suite: 282 passed.
  • Ruff lint/format and ty checks, including consumer signatures and generated async methods.
  • Loopback gRPC transport tests for the affected sync/async behavior.
  • SDK wheel built, verified, and imported from a clean checkout at stack head.
  • Fern check: zero errors; documentation navigation passes.
  • Live gateway integration (not run; this change does not modify sandbox infrastructure).

Checklist

  • Follows Conventional Commits.
  • Commits are signed off (DCO).
  • Python implementation and public SDK documentation updated.

Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

@maxdubrinsky
maxdubrinsky deleted the feat/5166-sandbox-watch-completion/maxdubrinsky branch November 3, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant