Skip to content

fix(install): preserve literal dots in RPM asset fallback - #5129

Closed
vineethsai7 wants to merge 2 commits into
NVIDIA:mainfrom
vineethsai7:fix/4768-install-awk-escape
Closed

vineethsai7 wants to merge 2 commits into
NVIDIA:mainfrom
vineethsai7:fix/4768-install-awk-escape

Conversation

@vineethsai7

@vineethsai7 vineethsai7 commented Nov 2, 2026 •

Copy link
Copy Markdown

Summary

Prevent RPM installs from printing awk escape warnings and require literal dots in fallback asset names.

Related Issue

Closes #4768

Changes

  • Use [.] for the literal dots in the three RPM fallback regexes so they pass through awk's -v processing intact.
  • Cover fallback selection for the CLI, gateway, and prover packages with gawk, mawk, and BusyBox awk when available. The tests reject malformed separators and fail on any stderr output.

Release Notes

RPM installs no longer show awk escape warnings during package selection.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)
  • ~/dc-eh/bin/dcb up-os-4768 "nice -n 15 tasks/scripts/test-install-sh.sh" — passed; gawk, mawk, and BusyBox were installed on the build host.
  • ~/dc-eh/bin/dcb up-os-4768 "nice -n 15 bash -c 'shellcheck -S warning install.sh && shellcheck -S error tasks/scripts/test-install-sh.sh && sh -n install.sh && bash -n tasks/scripts/test-install-sh.sh'" — passed.
  • Unqualified ShellCheck remains nonzero on existing findings, including six warning-level SC2034/SC2154 findings in the test script.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Review follow-up

  • P2 — Installer regression test absent from branch checks: Fixed in 9889efd4fd65c9b4447679ec89ece109a5d972e4. The Linux CI job installs gawk and runs the focused installer test on both architectures. No actionable GitHub review comments were posted.

Signed-off-by: Vineeth Sai Narajala <vnarajal@cisco.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T17:23:06.686756Z 4514a61 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vineethsai7

Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

Signed-off-by: Vineeth Sai Narajala <vnarajal@cisco.com>
@vineethsai7

Copy link
Copy Markdown
Author

Closing this in favour of #4845, which was opened first and fixes the same warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(install): install.sh prints gawk "escape sequence \. treated as plain ." warnings on RPM hosts

1 participant