Repository navigation
fix(install): preserve literal dots in RPM asset fallback - #5129
Closed
vineethsai7 wants to merge 2 commits into
Closed
vineethsai7 wants to merge 2 commits into
vineethsai7 wants to merge 2 commits into
Conversation
Signed-off-by: Vineeth Sai Narajala <vnarajal@cisco.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Signed-off-by: Vineeth Sai Narajala <vnarajal@cisco.com>
vineethsai7
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 2, 2026 18:09
Author
|
Closing this in favour of #4845, which was opened first and fixes the same warnings. |
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent RPM installs from printing awk escape warnings and require literal dots in fallback asset names.
Related Issue
Closes #4768
Changes
[.]for the literal dots in the three RPM fallback regexes so they pass through awk's-vprocessing intact.Release Notes
RPM installs no longer show awk escape warnings during package selection.
Testing
~/dc-eh/bin/dcb up-os-4768 "nice -n 15 tasks/scripts/test-install-sh.sh"— passed; gawk, mawk, and BusyBox were installed on the build host.~/dc-eh/bin/dcb up-os-4768 "nice -n 15 bash -c 'shellcheck -S warning install.sh && shellcheck -S error tasks/scripts/test-install-sh.sh && sh -n install.sh && bash -n tasks/scripts/test-install-sh.sh'"— passed.Checklist
Review follow-up
9889efd4fd65c9b4447679ec89ece109a5d972e4. The Linux CI job installs gawk and runs the focused installer test on both architectures. No actionable GitHub review comments were posted.