Skip to content

test(windows): backport server test repairs from #4862 - #5077

Merged
shailendra-nv merged 1 commit into
windowsfrom
test/4861-windows-suite-backport/shailendra-nv
Oct 30, 2026
Merged

shailendra-nv merged 1 commit into
windowsfrom
test/4861-windows-suite-backport/shailendra-nv

Conversation

@shailendra-nv

@shailendra-nv shailendra-nv commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Backport the two missing server-test fixes from #4862 to windows. Windows CI currently fails the SQLite concurrent-write fixture with database is locked; the upstream repair reduces Windows-only write iterations and avoids Windows timer rounding in the mutation-lock stress test.

Related Issue

Refs #4861 and #4862. This is a localized backport of already-reviewed test repairs; no new issue is required.

Changes

  • Use five SQLite write iterations per writer on Windows and retain 25 elsewhere.
  • Hold stress-test locks until a wall-clock deadline while yielding to other tasks.
  • Preserve the Windows branch's portable supervisor fixtures. The isolation modules changed by test(windows): repair the Windows MSVC test suite #4862 are absent from this branch, so this backport changes only the two applicable server test files.

Testing

  • mise run pre-commit passed.
  • Existing unit tests updated; native ARM64 workspace suite passed.
  • E2E tests: not applicable to these test-only changes.
Suite Command Total Passed Skipped/ignored Failed Result
Native Windows ARM64 workspace mise run --skip-tools windows:test:arm64 6,671 6,630 41 0 PASS
SBOM tooling (through mise run ci) uv run --no-project --with pytest pytest -o "python_files=*_test.py" deploy/sbom/ 10 10 0 0 PASS
Security release-range tooling (through mise run ci) uv run --no-project --with pytest pytest tasks/scripts/codex_security_release_range_test.py 9 9 0 0 PASS
Security diagnostics tooling (through mise run ci) uv run --no-project --with pytest pytest tasks/scripts/codex_security_diagnostics_test.py 14 10 3 1 FAIL
All reported test executions — 6,704 6,659 44 1 FAIL

The 41 skips are the existing Nextest skips, including ignored runtime tests. Package exclusions and cfg-hidden tests are outside those totals. x64 was not run on this ARM64 host.

Pre-commit used the already-installed x64 Python 3.14.5 and the exact pinned Biome 2.5.4 x64 executable to work around native ARM64 tool failures; repository dependencies are unchanged. Rust checks and tests ran natively on ARM64.

Repository-wide mise run ci stopped in the unchanged test_missing_invalid_and_symlinked_reports_do_not_echo_contents: Path.symlink_to() raised WinError 1314 because this Windows session lacks the symlink-creation privilege. The diagnostics suite also skipped three platform-specific checks. Later CI tasks did not run; no full-repository CI pass is claimed. The affected native Rust workspace suite and pre-commit both passed.

Checklist

  • Follows Conventional Commits.
  • Commit is signed off for DCO.
  • Architecture and published docs reviewed: no runtime behavior, API, schema, or command changes.

Reduce the SQLite concurrency fixture to five iterations per writer on
Windows so slow fsync does not exhaust the busy timeout. Hold mutation
stress-test locks until a wall-clock deadline rather than depending on
Windows timer granularity.

Retain Windows' existing portable supervisor fixtures. The isolation
validation modules changed by #4862 are not present on this branch.

Native Windows ARM64 validation: 6630 tests passed, 41 skipped, 0 failed.

Backported from commit 92434dc.

Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-30T20:49:24.654234Z 958efaa PR opened
🔒 Security Review ✅ Completed 2026-10-30T20:50:57.276456Z 958efaa PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@shailendra-nv shailendra-nv added the test:windows Run native Windows x64 and ARM64 lint/tests on PR mirrors label Oct 30, 2026 — with ChatGPT Codex Connector
@shailendra-nv
shailendra-nv enabled auto-merge (squash) October 30, 2026 20:49
@shailendra-nv shailendra-nv self-assigned this Oct 30, 2026
@shailendra-nv
shailendra-nv merged commit 958efaa into windows Oct 30, 2026
17 of 19 checks passed
@shailendra-nv
shailendra-nv deleted the test/4861-windows-suite-backport/shailendra-nv branch October 30, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:windows Run native Windows x64 and ARM64 lint/tests on PR mirrors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant