Skip to content

fix(ci): allow accepted protobuf breaks for v0.1.6 prereleases - #4976

Merged
TaylorMutch merged 4 commits into
mainfrom
fix/accepted-protobuf-breaks/TaylorMutch
Oct 27, 2026
Merged

TaylorMutch merged 4 commits into
mainfrom
fix/accepted-protobuf-breaks/TaylorMutch

Conversation

@TaylorMutch

@TaylorMutch TaylorMutch commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Allow the release captain's accepted protobuf breaking changes for all v0.1.6-pre.N candidates so that replacement candidates retain the exception if an earlier prerelease fails. The current v0.1.6-pre.6 run fails because ResumeBoundaryRequest field 3 was renamed from allow_cold_start_fallback to restart_if_restore_fails, including its JSON name.

Maintainer Note

(Human authored by @TaylorMutch ) We discussed the change introduced in #4765 to ResumeBoundaryRequest is okay to change since the suspend/resume functionality is still experimental in 0.1.6, and the change matches the changes. This PR will be reverted after the 0.1.6 release.

Related Issue

Build/qualification fix under the contributor write-access exception. The author has verified ADMIN access to NVIDIA/OpenShell. No separate issue is required.

Failing qualification: https://github.com/NVIDIA/OpenShell/actions/runs/40510035436/job/122219159143

Changes

  • Enable the exception only for prereleases in the v0.1.6-pre.N train. Other versions and stable tags retain normal enforcement. The checker verifies that the exception matches the exact candidate tag and has a reason.
  • Continue compiling both protobuf snapshots and running Buf. Accept breaking-change diagnostics for this patch train while preserving compilation and tooling failures.
  • Record each candidate's exact exception tag and reason in the run summary and qualification JSON. All qualification suites must still report success, and stable promotion still requires a successful full prerelease run.
  • Document the temporary exception and its removal after promoting v0.1.6 in CI and release-captain guidance.

The exception accepts all protobuf compatibility findings for this patch train. Review each candidate's full protobuf diff and include migration guidance in the release notes. SDK/configuration advisory findings still require their own disposition.

Rollback after v0.1.6

Squash-merge this PR. This is a temporary release exception; after stable v0.1.6 publication is verified, open a cleanup PR reverting the entire squash-merge commit:

git revert --no-commit <PR-4976-squash-merge-sha>
git commit --signoff -m "revert(ci): remove temporary v0.1.6 protobuf exception"

This removes the workflow exception, checker support, qualification metadata, dedicated tests, and temporary guidance together. Use the final squash-merge SHA from this PR. Run Actionlint and the normal protobuf compatibility check on the cleanup. The workflow and release-captain skill link the rollback procedure in CI.md.

Validation: the full PR patch passes git apply --reverse --check against the current branch. Keep subsequent exception changes in this PR before squash-merging so the rollback stays a single commit.

Release Notes

Testing

  • Focused pytest suite: 31 passed, including replacement prereleases, exact candidate-tag matching, qualification evidence, and real Buf field-rename checks.
  • Compilation and tooling errors remain fatal; failed or skipped qualification jobs still prevent promotion.
  • Ruff lint and formatting checks.
  • Actionlint v1.7.12 on the changed workflow.
  • ShellCheck and Bash syntax validation on qualification-summary generation.
  • Markdown lint and affected release guidance consistency checks.
  • git diff --check.
  • Full prerelease qualification: run after merge on a new candidate containing these changes.

Checklist

  • Follows Conventional Commits.
  • Commits signed off for DCO.
  • Related CI and contributor guidance updated.

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch TaylorMutch changed the title fix(ci): allow accepted protobuf breaks for one prerelease fix(ci): allow accepted protobuf breaks for v0.1.6 prereleases Oct 27, 2026
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch
TaylorMutch marked this pull request as ready for review October 27, 2026 15:26
SDAChess
SDAChess previously approved these changes Oct 27, 2026
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch
TaylorMutch added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit ac7f615 Oct 27, 2026
80 of 81 checks passed
@TaylorMutch
TaylorMutch deleted the fix/accepted-protobuf-breaks/TaylorMutch branch October 27, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants