Repository navigation
fix(ci): allow accepted protobuf breaks for v0.1.6 prereleases - #4976
Merged
Merged
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
TaylorMutch
marked this pull request as ready for review
October 27, 2026 15:26
TaylorMutch
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 27, 2026 15:26
SDAChess
previously approved these changes
Oct 27, 2026
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
SDAChess
approved these changes
Oct 27, 2026
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the release captain's accepted protobuf breaking changes for all
v0.1.6-pre.Ncandidates so that replacement candidates retain the exception if an earlier prerelease fails. The currentv0.1.6-pre.6run fails becauseResumeBoundaryRequestfield 3 was renamed fromallow_cold_start_fallbacktorestart_if_restore_fails, including its JSON name.Maintainer Note
(Human authored by @TaylorMutch ) We discussed the change introduced in #4765 to
ResumeBoundaryRequestis okay to change since the suspend/resume functionality is still experimental in 0.1.6, and the change matches the changes. This PR will be reverted after the 0.1.6 release.Related Issue
Build/qualification fix under the contributor write-access exception. The author has verified ADMIN access to NVIDIA/OpenShell. No separate issue is required.
Failing qualification: https://github.com/NVIDIA/OpenShell/actions/runs/40510035436/job/122219159143
Changes
v0.1.6-pre.Ntrain. Other versions and stable tags retain normal enforcement. The checker verifies that the exception matches the exact candidate tag and has a reason.The exception accepts all protobuf compatibility findings for this patch train. Review each candidate's full protobuf diff and include migration guidance in the release notes. SDK/configuration advisory findings still require their own disposition.
Rollback after v0.1.6
Squash-merge this PR. This is a temporary release exception; after stable v0.1.6 publication is verified, open a cleanup PR reverting the entire squash-merge commit:
This removes the workflow exception, checker support, qualification metadata, dedicated tests, and temporary guidance together. Use the final squash-merge SHA from this PR. Run Actionlint and the normal protobuf compatibility check on the cleanup. The workflow and release-captain skill link the rollback procedure in CI.md.
Validation: the full PR patch passes
git apply --reverse --checkagainst the current branch. Keep subsequent exception changes in this PR before squash-merging so the rollback stays a single commit.Release Notes
Testing
git diff --check.Checklist