Skip to content

ci(review): move unaccepted PRs back to draft - #4948

Draft
purp wants to merge 18 commits into
NVIDIA:mainfrom
purp:ci/4839-draft-unaccepted-prs/purp
Draft

purp wants to merge 18 commits into
NVIDIA:mainfrom
purp:ci/4839-draft-unaccepted-prs/purp

Conversation

@purp

@purp purp commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Move unaccepted PRs back to draft when opened ready for review or marked ready, before requesting reviewers. Accept authors with write access or state:accepted on the PR or a referenced issue. Explain the first automatic conversion with one comment; subsequent unaccepted attempts return to draft without another comment.

Depends on #4863. This branch includes its reviewer registry and routing changes; the acceptance layer can be reviewed separately in this comparison.

Related Issue

Related to #4839. Illustrative draft policy is tracked separately in #4952.

Changes

  • Share one acceptance implementation between Review Readiness and PR Issue Acceptance, removing the duplicate JavaScript helper.
  • Preserve the existing acceptance check's name, triggers, and read-only behavior, using the PR event payload for its metadata.
  • Check referenced issues, stop at the first accepted issue, and validate acceptance before loading the reviewer roster.
  • Add the requested first-conversion comment and suppress repeats using the existing PR comment history.
  • Remove the mechanism explanation from CONTRIBUTING.md and prune duplicated and low-value tests.

Testing

  • 56 focused Python tests pass, covering both callers, PR/issue acceptance, one-time comments, pagination, reviewer preservation, and failure boundaries.
  • Read-only live GraphQL/CLI checks, workflow shell syntax, and whitespace checks pass.
  • Ruff, Actionlint, and Markdown lint were unavailable; downloads are blocked.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

purp added 16 commits October 22, 2026 17:04
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

purp added 2 commits October 27, 2026 02:01
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant