Repository navigation
fix(sdk/go): fall back to system active gateway - #4917
Open
ericcurtin wants to merge 1 commit into
Open
ericcurtin wants to merge 1 commit into
ericcurtin wants to merge 1 commit into
Conversation
Match the CLI: use the system active_gateway when the user one is missing or invalid. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@TaylorMutch @SDAChess could you please triage #4517 so the issue check can pass? PTAL, and |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fall back to the system
active_gatewaywhen the user one is missing or invalid, like the CLI.Related Issue
Closes #4517
Changes
resolveActiveGatewaytries the user file, then<system dir>/active_gateway./etc/openshell.Testing
Ran
go test ./...andgolangci-lint runinsdk/go.Checklist