Skip to content

fix(host_pattern): reject '**' as a substring within a DNS label #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x5t4l1n wants to merge 1 commit into from
+11 −0
Closed

fix(host_pattern): reject '**' as a substring within a DNS label #4904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions crates/openshell-core/src/host_pattern.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,17 @@ impl HostPattern {
if label == "**" {
return Ok(HostLabelPattern::Recursive);
}
// `**` is only valid as an entire label. A label containing `**`
// as a substring (e.g. `api**`) is ambiguous because the glob
// crate silently treats it as a single-label wildcard while the
// documented semantics reserve `**` for multi-label matching.
// Reject it loud so callers get consistent behaviour.
if label.contains("**") {
return Err(format!(
"host pattern label {label:?} contains '**' as a substring; \
'**' is only valid as a complete label (e.g. '**.example.com')"
));
}
let pattern = glob::Pattern::new(label)
.map_err(|error| format!("invalid host pattern: {error}"))?;
Ok(HostLabelPattern::Label {
Expand Down
Loading