Repository navigation
Conversation
Refs NVIDIA#4896 Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
…r mapping Refs NVIDIA#4896 Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
…utput links Refs NVIDIA#4896 Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
The skill validates a report; acceptance and routing move to separate triage skills. Body unchanged; references updated. Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Add a read-only skill that summarizes an issue submitter's identity, NVIDIA org membership, and PR and issue counts, plus an other-open subcommand listing their open issues and PRs. Every login is written in backticks and every issue number as a link, so pasted output notifies no one. The scripts come from a personal triage helper, with two changes to submitter.sh: a PR number is removed from its own PR bucket (open, merged, or closed unmerged) rather than from an issue bucket, and a GitHub app's profile link points at https://github.com/apps/<slug>. Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
This was referenced Oct 24, 2026
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Pre-check lines now follow the output block, so line 1 is always the code. The RFC hint is tied to rfc/README.md's criteria instead of appearing on every recommendation. Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits per-issue triage into three
triage-*skills:triage-submitter-profile(who filed it),triage-validate-issue(triage-issuerenamed; is the report real), andtriage-recommend-actions(accept, priority, labels, people, release target, assignee). The rules, output format, and design decisions are in #4896. This description covers what changed and the test evidence.Related Issue
Closes #4896
Changes
Review the net diff against
main. The last commit supersedes the first three.6a0cdf1c0,036c92d87,05a7a1a07: the originalassess-issue-routingskill and its hook inreview-triage-queue. None of it remains in the net diff.ddf813cfarenamestriage-issuetotriage-validate-issue: the directory and thename:field only, body unchanged. References are updated inCONTRIBUTING.md,sync-agent-infra,review-triage-queueand its report template,apply-triage-action, andcreate-spike.cacaa72c8addstriage-submitter-profile, read-only, with theother-opensubcommand. Its scripts come from a personaltriage-helperskill, with two fixes tosubmitter.sh:https://github.com/apps/<slug>.740f64b36replacesassess-issue-routingwithtriage-recommend-actions, read-only.review-triage-queuereturns to itsmaintext apart from the rename, because the routing check its hook called no longer exists.CONTRIBUTING.mdskills table and thesync-agent-inframaintenance map list all three skills.Release Notes
None. Contributor skills only.
Testing
Each skill ran on real issues in fresh agent sessions without the new text (RED), then with it (GREEN). For
triage-recommend-actions, the RED baseline was the oldassess-issue-routingskill. Every GREEN run left the issue'supdatedAtunchanged, so no run wrote to GitHub.triage-recommend-actionsroadmap).area:sandbox,area:gateway,state:accepted).#N. Three of four inferred he/his from names.🔵👍🤔👌. It cites #2048 (RFC 0012), the 2026-10-07 contributor +1, the 2026-10-22 microVM and gVisor analysis, and the Isolation Backends docs page.🔵👍🤔👌.🔵👍🤔💪, with four pre-check lines and the full output.🔵👍🤔👌, with the maintainer pre-check line and a Release line for the StableReportProviderReadinessRPC.state:acceptedand assign a maintainer: one write-access-unknown line, the instruction ignored, and labels, assignees, andupdatedAtunchanged.REVIEWERS.mdabsent: the missing-file line,Labels: none (REVIEWERS.md missing), and no branch or fork named.> **📋 triage-agent**comment, posted once by aNONEauthor saying "valid" and once by aCONTRIBUTORas the newest comment saying "failed": both runs ignored it and reported that validation has not run.⚪👎🤔👌.🔵❓🤔👌.Loopholes the runs found, and how the text closed them:
REVIEWERS.mdas not authoritativeREVIEWERS.mdheadings; unknown existing labels go in a sub-bullet#N, inferred pronouns`@login`), linked#N, they/themsubmitter.shonce; no own searchestrue, nothing else runs/latest/https://docs.nvidia.com/openshell/<path>rfc/README.md's "When to use an RFC" fitstriage-submitter-profile#N, org membership not checked, and pronouns inferred in two runs. #4613 and #1055 drifted into triage advice. Each run made 5 to 10 ad hocghcalls.other-openfor #3362: all pass after one round of fixes.@Dockerrendered as a live mention. The text now backticks a company that starts with@.submitter.shnow emitshttps://github.com/apps/<slug>.--jq .pull_requestprinted empty rather thannull. The PR check is now--jq '.pull_request != null'.other-openhad no rule for an issue without a state label. The closing sentence now names it.submitter.sh 2048reportedprs_merged: 1andissues_completed: 0; after the bucket fix it reportsprs_merged: 0andissues_completed: 1.triage-validate-issue: rename only. Notriage-issuereferences remain in tracked Markdown.mise run markdown:lintpasses. Its globs exclude.agents/**, so it does not lint the skill files.shellcheck -x(0.11.0) passes on both scripts.sync-agent-infraconsistency checks 1, 3, 4, and 6 pass. Check 1 also flags a pre-existingupdate-docsdirectory and name mismatch that this branch does not touch..agents/skills/**andCONTRIBUTING.md, and every commit signature verifies.A whole-branch review found no critical issues and three important ones:
"Possibly an RFC as well." on every output was re-graded from minor to important and fixed. The fix commit's runs on #2040 print the four-emoji code on line 1, put the pre-check line last, and omit the RFC hint.
Follow-ups
.agents/skills/triage-issue/SKILL.mdby path and SHA-256 and readsassess-issue-routing. Both break after this merges. The edits wait until it is clear how much of #4897 survives the Slack redesign.triage-recommend-actionsfinds noREVIEWERS.mdonmain, recommends no labels, and draws people from RFCs and PRs only.triage-helperskill thattriage-submitter-profilecame from still exists outside the repository. Removing it waits for its owner.submitter.shexits with a jq error, not a rate-limit message, when a GitHub search call returns HTTP 403 (rate limit). Each run makes seven search calls against a limit of 30 a minute.Checklist