Skip to content

feat(helm): add certificate hook pod labels and annotations - #4895

Merged
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
crookedstorm:job-metadata/crookedstorm
Oct 24, 2026
Merged

TaylorMutch merged 1 commit into
NVIDIA:mainfrom
crookedstorm:job-metadata/crookedstorm

Conversation

@crookedstorm

@crookedstorm crookedstorm commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

There are times when you need to set labels or annotations for any number of reasons on even a lowly hook job pod. This allows the users to do that in Kubernetes when deploying via helm.

Related Issue

Closes #4894

Changes

Release Notes

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Brooke Storm <brookes@nvidia.com>
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@crookedstorm

Copy link
Copy Markdown
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@crookedstorm

Copy link
Copy Markdown
Contributor Author

recheck

@TaylorMutch
TaylorMutch added this pull request to the merge queue Oct 24, 2026
Merged via the queue into NVIDIA:main with commit c4688aa Oct 24, 2026
82 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: allow helm chart to pass metadata to job pods

2 participants