Repository navigation
Conversation
Widen the github-gator provider's repo-scoped rules from NVIDIA/OpenShell
to {NVIDIA,ai-openshell}/{OpenShell,OpenShell-ghsa-*} so gator can read and
review pull requests in GitHub security advisory private forks. The search
rule already matches the forks and is unchanged.
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let gator reach GitHub security advisory private forks (
OpenShell-ghsa-*) so it can review pull requests opened there. Thegithub-gatorprovider's repo-scoped rules allowed onlyNVIDIA/OpenShell, so the sandbox denied every request to a fork.Related Issue
No issue. This is a small agent-tooling change by a maintainer. Without it, gator can't reach advisory fork PRs at all.
Changes
scripts/agents/gator/providers/github-gator.yaml: the repo-scoped rules forapi.github.com,github.com(including the git smart-HTTP paths), andcodeload.github.comnow match{NVIDIA,ai-openshell}/{OpenShell,OpenShell-ghsa-*}instead ofNVIDIA/OpenShell. Theai-openshellorg is included now so the rules don't need another change when work moves there.OpenShell-Community,OpenShell-Windows, andOpenShell-Researchstill don't match.search/issuesrule is unchanged.*repo:NVIDIA/OpenShell*already matches the forks.Testing
openshell profile lint --file scripts/agents/gator/providers/github-gator.yamlpassesglob.match(pattern, ["/"], path)on regorus 0.9.1, the engine the sandbox policy uses. All 21 cases passed: the forks andNVIDIA/OpenShellmatch, whileOpenShell-Community,-Windows,-Research, other orgs, lowercasenvidia, and nested repo names don't.Checklist