Skip to content

fix(providers): harden static credential placement #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johntmyers wants to merge 2 commits into
base: main
Choose a base branch
from
+1,718 −73
Open

fix(providers): harden static credential placement #4886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc8d7e
fix(providers): enforce static credential request placement
johntmyers Oct 23, 2026
8531c4b
fix(providers): enforce placement using existing credential metadata
johntmyers Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions crates/openshell-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,21 @@ router agree on provider defaults. Profiles define:
Do not duplicate provider-specific inference behavior in callers. Add shared
behavior here, then consume it from the gateway, sandbox, and router.

## Static Credential Resolution

Static credential bindings retain endpoint authorization. The gateway includes
static `ProviderProfileCredential` auth metadata in the existing runtime
credential map under `static-env:<ENV_KEY>`. Provider state extracts those entries
before storing dynamic token grants and compiles placement locally alongside the
matching static binding. Missing metadata preserves legacy endpoint-scoped
substitution; malformed reserved metadata fails closed atomically.

Request rewriting supplies the actual header name, query key, or path slot.
Header authorization is independent of authentication scheme, including Basic.
Explicit body/WebSocket rewrite policies and trusted signing retain their
existing permissions. Existing placeholder and stable-handle derivation remain
unchanged. Protobuf message shapes and service interfaces remain unchanged.

## Middleware Contracts

Built-in supervisor middleware identifiers, host-selector matching, and pure
Expand Down
Loading
Loading