Repository navigation
Conversation
…om main Prior to this change, the Windows MSVC lint and test job ran only on pull-request mirrors labeled test:windows. Most PRs never ran it, and main broke on Windows across five PRs before an unrelated labeled PR exposed 15 failing tests (#4861). The job also ran cold every time: the cache-seed job ran only on pushes to the windows branch, and GitHub scopes caches by branch, so pull-request mirrors could never restore that cache. Rust cache hits were 0% and each run took about 40 minutes. Now, every pull-request mirror runs the Windows lint and test job without a label. Pushes to main run the cache-seed job, which reports failures normally there, so a Windows break on main shows up within one merge. Main runs are not cancelled by later pushes, so each seed finishes. Pull-request runs restore the main cache but no longer save their own, since no other branch can restore it and saving it only evicts the main cache. Release-binary builds stay on the windows branch. The checks remain non-required for merging. CI.md, the Windows build skill, the principal engineer reviewer agent, and the gator gate skill no longer refer to the test:windows label. Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 23, 2026 19:16
Signed-off-by: Kris Hicks <khicks@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the Windows MSVC lint and test job on every PR instead of only on PRs labeled
test:windows, and seed its Rust cache frommainso PR runs start warm.Related Issue
None. Exempt from the issue requirement by maintainer decision. Background:
mainbroke on Windows across five PRs before an unrelated labeled PR exposed 15 failing tests (#4861, fixed by #4862).Changes
mainto the push triggers and run the cache-seed job there. Failures onmainreport normally; thewindowsbranch stays advisory.mainruns, so each seed finishes despite frequent merges.maincache.windowsbranch only.CI.md, thebuild-openshell-mxc-windowsskill, the principal engineer reviewer agent, and the gator gate skill (and its test assertions) to drop thetest:windowslabel.The Windows checks stay non-required for merging. Once warm-cache run times are known, they can be considered for the required set.
Testing
actionlintreports no new findings forwindows-msvc.yml(the three PowerShell SC2086 notes also appear onmain)markdownlint-cli2passes on the changed Markdown filestest:windowslabelChecklist