Skip to content

docs(contributing): exempt build and flaky-test fixes from the issue requirement - #4875

Merged
krishicks merged 1 commit into
mainfrom
docs/build-fix-issue-exemption/krishicks
Oct 23, 2026
Merged

krishicks merged 1 commit into
mainfrom
docs/build-fix-issue-exemption/krishicks

Conversation

@krishicks

Copy link
Copy Markdown
Collaborator

Summary

Let authors with repository write access open PRs that only fix a broken build or flaky tests without filing a separate issue.

Related Issue

None. Maintainer-approved exemption from the issue requirement.

Changes

  • CONTRIBUTING.md: add the build and flaky-test exception for authors with WRITE, MAINTAIN, or ADMIN access, and show how branch names omit the issue ID when there is no issue.
  • .github/PULL_REQUEST_TEMPLATE.md: mention the new exception in the Related Issue comment.
  • create-github-pr skill: match the new rule; a PR without an issue describes the failure in its Related Issue section.
  • sync-agent-infra skill: update the consistency check to the new rule.

Authors without write access still need an accepted issue. The PR Issue Acceptance workflow already passes write-access authors without checking linked issues, so it needs no change.

Testing

  • markdownlint-cli2 passes on the changed Markdown files

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

…requirement

Prior to this change, CONTRIBUTING.md, the PR template, and the
create-github-pr skill required every PR except automated dependency
updates to close an issue. A maintainer fixing a broken build or flaky
tests had to file an issue that only restated the failure the PR already
describes.

Now, authors with WRITE, MAINTAIN, or ADMIN access may open a PR that
only fixes a broken build or flaky tests without a separate issue, and
describe the failure in the PR instead. Authors without write access
still need an accepted issue; the PR Issue Acceptance workflow already
passes write-access authors without checking for linked issues, so it
needs no change. The branch naming rule now covers PRs without an issue,
and the sync-agent-infra consistency check states the new rule.

Signed-off-by: Kris Hicks <khicks@nvidia.com>
@krishicks
krishicks enabled auto-merge October 23, 2026 14:31
@krishicks
krishicks disabled auto-merge October 23, 2026 14:31
@krishicks
krishicks enabled auto-merge October 23, 2026 14:31
@krishicks
krishicks added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 5bfe2fb Oct 23, 2026
81 checks passed
@krishicks
krishicks deleted the docs/build-fix-issue-exemption/krishicks branch October 23, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants