Repository navigation
Conversation
Keep NVIDIA injection under Docker driver ownership and validate the persisted selection during admission and restart. Closes NVIDIA#4849 Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
I have read the DCO document and I hereby sign the DCO. |
WSL hardware validationTested implementation: A fresh qualification on Docker Desktop WSL2 passed for the explicit Environment: NVIDIA RTX Spark N1X, WSL Ubuntu 24.04 ARM64, kernel
Each CUDA probe returned: {"uid":998,"devices":1,"kernel_result":42,"cuda":"pass"}Enforcement probes confirmed denied writes outside permitted paths, denied direct network access, zero effective capabilities, The script initially attempted exec while gateway recovery still reported Provisioning and exited. After confirming that the same sandbox reached Ready, we continued the remaining probes successfully without recreating it or repeating the gateway restart. The early failed probe and successful continuation logs are retained separately. Raw qualification logs are retained on the test host under GitHub validation remains separate: Branch Checks and Helm Lint await maintainer |
|
recheck |
Summary
Support explicit all-GPU NVIDIA injection through ordinary Docker Desktop WSL sandbox creation. Preserve OpenShell ownership of the workload, protected GPU selection and restart admission while keeping existing CDI behavior unchanged.
Depends on #4204; the tested parent revision is
33350a881f55011286e7c3a68d8007e43e50e0bf.Related Issue
Closes #4849
Changes
docker.nvidia_wsl_gpus=all, limited to Docker Desktop WSL and rejecting conflicting CDI or counted GPU requests.Testing
Hardware evidence: #4837 (comment)
The test used the local uncommitted patch on the parent revision, identified by compressed patch SHA256
9791d6251efe4f958d460d62cb9cbc5f09646edcd0a1d0c5683455a580683c71. Local commitc0730ecb8c9c8a4562af534ca717af72a06ddd61matches the tested implementation patch; its only additional change is runtime-overview documentation. The SSH signature was verified locally. Hardware: RTX Spark N1X, Ubuntu24.04 WSL2, Docker Desktop4.96.0 / Engine29.9.1, NVIDIA620.66. Development gateway transport was used. Jetson, x86 hardware, individual GPU selection, model inference and production transport are not qualified by this evidence.Checklist
Draft review context
Opened as a draft following Jim Meyer's invitation to share the proposed approach for review, relayed by the author. Issue #4849 still awaits
state:accepted; the author currently has Read access to the upstream repository. The issue-acceptance check may remain red until maintainers record acceptance. This draft does not claim acceptance or merge readiness.The PR targets #4204's branch to isolate this change. Retarget and reconcile validation after the dependency lands; the closing reference takes effect when this work reaches the default branch.