Repository navigation
fix(gateway): require authentication or explicit development opt-in - #4821
TaylorMutch wants to merge 1 commit into
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4821.docs.buildwithfern.com/openshell |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. configuration — No explicit risk acceptance foundWithout OIDC, mTLS user/operator authentication, or configured/discovered gateway JWTs, openshell-gateway previously warned and started but now rejects startup when allow_unauthenticated_users is omitted or false.
Review details
Advisory review; publication gates are unchanged. |
|
Label |
|
We acknowledge this is a change but it fixes a bug and guides users towards the proper UX for configuring auth. |
Summary
Reject gateway startup when no OIDC issuer, mTLS user authentication, operator authentication, or gateway JWTs are configured unless unauthenticated users are explicitly allowed. The configuration error appears before tracing services and listeners start and includes the supported authentication options and development opt-in.
Related Issue
Closes #4814
Changes
Release Notes
Gateways without OIDC, mTLS user or operator authentication, or gateway JWTs now refuse to start. For trusted local development, explicitly set
allow_unauthenticated_users = trueunder[openshell.gateway.auth].Testing
Passed:
cargo test --locked -p openshell-server --features test-support --lib: 2,370 passed, 21 ignored.cargo clippy --locked -p openshell-server --features test-support --all-targets -- -D warningscargo fmt -p openshell-server -- --checkmise run docs: no errors; three Fern warnings.git diff --check.Full deployment e2e suites have not been run. Inspected the dev task, Docker Compose, Helm CI, and Docker/Podman e2e configurations: they already opt into unauthenticated users or configure gateway JWTs. This draft leaves deployment e2e validation outstanding.
Checklist