Repository navigation
Conversation
danehans
marked this pull request as ready for review
October 5, 2026 21:21
danehans
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 5, 2026 21:21
danehans
marked this pull request as draft
October 5, 2026 22:09
2 of 11 tasks
|
This pull request has had no activity for 14 days and is now marked stale. |
github-actions
Bot
added
the
state:stale
Contributor
|
Heads-up: the Go SDK moves to ai-openshell/sdk-go on 2026-11-03 (#5031). This PR also changes hand-written SDK code under |
danehans
force-pushed
the
feat/4009-conditional-sandbox-stop/danehans
branch
from
November 2, 2026 19:53
f328b54 to
1fe5ddb
Compare
Bind conditional stops and extension credentials to each launch. Preserve historical receipts across retries and reject stale execution identities. Fixes: NVIDIA#4009 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Preserve identity on persisted start retries and rotate it for new recovery launches. Update compatibility checks and suspend/resume coverage. Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
danehans
force-pushed
the
feat/4009-conditional-sandbox-stop/danehans
branch
from
November 2, 2026 20:20
1fe5ddb to
2b1968a
Compare
github-actions
Bot
removed
the
state:stale
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow controllers to stop only the sandbox execution that produced an attested observation. A delayed stop for an earlier execution cannot stop its replacement.
Related Issue
Fixes: #4009
Changes
Release Notes
Controllers can pass
--execution-idto stop the execution they observed. Stale requests leave newer executions running.Testing
mainat634ca7d8; GitHub reports the branch mergeable.cargo test -p openshell-server --lib(2,617 passed); Rust SDK and focused CLI tests passed.mise run go:ci, Clippy for the affected Rust crates,cargo fmt --check, and Markdown lint passed.mise run e2e:kuberneteswithOPENSHELL_E2E_KUBE_TEST=sandbox_execution_stop: 1 focused test and Kubernetes conformance passed.Checklist
Generated Rust
SandboxStatusstruct literals need the newexecution_idfield when rebuilt against this API. The Go SDK changes remain here pending the planned SDK migration in #5031. This PR remains a draft while the issue awaits maintainer acceptance and the required CI gate is blocked.