Repository navigation
Conversation
Resolve metadata paths through Git and watch ref directories so unchanged builds remain fresh while packed-to-loose branch updates refresh the embedded version. Track both private and shared reftable stores. Add Cargo invalidation regressions for ordinary clones, linked worktrees, branch and tag changes, detached HEAD, and source archives. Preserve the existing version calculation and protobuf generation. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 10:30
1 of 6 tasks
Keep the Git helper next to build_version.rs as build_git.rs instead of a path-mapped build_support module. Watch refs/heads and refs/tags rather than all of refs/, so fetch, push and stash no longer rerun the core build script, and cover that in the invalidation test. Shorten the contributor note to the behavior a contributor sees. Signed-off-by: Shiju <shiju@nvidia.com>
|
This pull request has had no activity for 14 days and is now marked stale. |
github-actions
Bot
added
the
state:stale
Signed-off-by: Shiju <shiju@nvidia.com>
Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
changed the title
github-actions
Bot
removed
the
state:stale
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #4947 with Git version tracking for packed-ref transitions, linked worktrees using reftable, and source archives nested inside another repository. #4947 already fixed the ordinary unchanged-worktree rebuild; this PR preserves that fix and covers the remaining metadata boundaries.
Related Issue
Closes #4186
Changes
.giton the package version, even when its parent directory belongs to a tagged repository.Release Notes
Git-derived version metadata stays current across additional ref-storage and archive layouts.
Testing
git_build_invalidationreceipt retained for the unchanged production helper.0.1.0after the branch advances.0.1.0instead of the package's9.8.7.The unchanged production-helper checks are reused; only the two cases affected by the stronger fixture setup were rerun. The current-main negative control uses the production main Git-watch functions unchanged, with a test-harness adapter for their signatures. This update makes no new performance claim; the original 8.920s/1.384s comparison predates #4947 and does not measure this follow-up.
Checklist