Skip to content

feat: allow helm chart to pass metadata to job pods #4894

Closed

Description

@crookedstorm

User Story

I am using OpenShell in Kubernetes and sometimes need it in a cluster with istio sidecar injection. Jobs will hang forever with that unless exempted. I work around this by explicitly excepting the jobs labels on the controller end of things, but that's unwieldy.

It want to set pkiInitJob.podLabels and pkiInitJob.podAnnotations in values when necessary.

Problem Statement

See above.

Impact / Why This Matters

Without this feature, I have to hack around by changing settings on the controller for istio. I'm quite sure there are other controllers that might need to treat the hook job differently than other pods.

Proposed Design

PR incoming. This is a simple ask.

Acceptance Criteria

  • I can set the above values or something very similar to apply arbitrary labels or annotations to the PKI hook job pod as required.

Alternatives Considered

I am using this to close an issue when my PR comes in. I honestly don't require a big design decision for this, but it's not really a bug either.

No alternatives are considered for simply improving the flexibility of the helm chart.

Agent Investigation

No response

Checklist

  • I've reviewed existing issues and the published docs
  • This is a design proposal, not a "please build this" request

Activity

  1. added
    state:acceptedA maintainer decided OpenShell should pursue this issue
    and removed
    state:triage-neededOpened without agent diagnostics and needs triage
    on Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    state:acceptedA maintainer decided OpenShell should pursue this issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions