Repository navigation
ci(e2e): prepare trusted OpenClaw 10.5 qualification - #13697
Draft
prekshivyas wants to merge 9 commits into
Draft
prekshivyas wants to merge 9 commits into
prekshivyas wants to merge 9 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/plugin
View coverage of the 10 most impacted files.
TypeScript / code-coverage/cli
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Contributor
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Prepare trusted E2E qualification for the OpenClaw 2026.10.5 upgrade in #12382. Admit the reviewed upgraded runtime and WeChat locks while preserving current main compatibility, and provision Python 3.13 for the Model Router job.
Reason
Full PR E2E executes these controls from trusted main. Run 40127403758 rejected the 10.5 lock before protected runtime qualification. Its Model Router job separately failed because the runner supplied Python 3.14, outside the supported range; that failure also reproduced on the exact base. Candidate-only changes cannot replace these trusted prerequisites.
Changes
Verification
Current candidate:
b129839300146cb50f32002f160ca29ed8780662. Normal isolated commit and actual pre-push hooks passed, including publication validation and CLI TypeScript. The commit is GitHub Verified. Validation cannot read host credentials; SSH transport runs outside that boundary.npm run checkfailed in the credential-denying macOS environment. Comparison with the published parent reproduced 631 of 647 failures; 15 passed without coverage, and one candidate fixture defect was repaired. No sandbox rule, deadline or assertion was weakened. This remains a classified failed local broad run.Parent
abde906235128e41ba5f38656c9a8b63418dbd5dpassed main CI on attempt 2. All 12 CLI shards, strict Pi receipts, distribution tests, audits, installer, SDK, plugin and type checks passed. The only first-attempt test failure was an unchanged terminal Ctrl-D package-contract case. Its diagnosed failed-job retry passed all 1,360 package-contract tests with ten skips; the timing cause remains unproven.That parent also passed managed-image qualification on Docker AMD64, Docker ARM64 and rootless Podman. Each lane verified 36 authenticated model requests, zero local builds, native 9.2 post-restart PONG, external-image lifecycles, 13 cleanup checks and ten empty final inventories. Podman proved Docker absence and no invocation. All seven artifact archives and source/run/cohort identities were verified.
The parent's Advisor review returned nine verified specialist reports: seven clear, one directory-sync finding repaired here, and one production-wiring false positive. This prerequisite retains main's 9.2 production Dockerfiles and runtime graph; #12382 wires the helper into its separate 10.5 image paths. The documentation now states that boundary. The failed Advisor gate is retained as evidence, not independent clearance.
This source repair changes image inputs. The current static check rejected the older Pi receipts because their source revision predates the shared metadata change. The strict check is unchanged. Both Pi jobs passed in image qualification. Their same-branch artifacts passed digest, source/run/cohort, entrypoint and credential-removal checks. The two receipts and authority hashes are staged locally; the strict receipt checker and all 17 candidate tests pass. This receipt repair is not yet committed or published; complete candidate evaluation remains required first. No unchanged retry is planned for this deterministic failure. The main CI run is now complete: 21 jobs passed, two were skipped, and only this static receipt check and its aggregate failed. All 12 CLI shards, actual distribution recovery tests, audits, installer, SDK, plugin and type checks passed. Advisor skipped after the CI failure and supplies no review clearance. Both OpenClaw producer jobs passed, and their artifact digests and source/run/cohort contracts were verified. Docker AMD64, Docker ARM64 and rootless Podman activation are running. Their cleanup evidence and independent review remain pending. Parent evidence does not qualify the new candidate.
Review notes
Self-review covers the complete four-file repair against the evaluated parent and canonical main
bbdd0bcf8913a537a1126a40a144bac4def5986f. The shared writer closes the directory descriptor on failure and retries sync even when replacement bytes are already present. The change makes no all-files transaction or general power-loss guarantee. No credential, live assertion, deadline or validator changes are included.The Model Router provider-routed inference recommendation remains required. Full default E2E for #12382 needs this prerequisite independently reviewed and landed on trusted main. Keep this PR draft until qualification and independent review pass.
Signed-off-by: Prekshi Vyas prekshiv@nvidia.com