Hi TN: implement natural cardinal verbalization for up to 3-digit numbers in address#456
Open
shrpawar-alt wants to merge 4 commits into
Open
Hi TN: implement natural cardinal verbalization for up to 3-digit numbers in address#456shrpawar-alt wants to merge 4 commits into
shrpawar-alt wants to merge 4 commits into
Conversation
…igit-by-digit reading for 4+ digits Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
shrpawar-alt
changed the title
mgrafu
reviewed
Jul 9, 2026
|
|
||
| any_street_num = (num_as_cardinal | pynutil.add_weight(digit_run_4_plus, -5.0)).optimize() | ||
|
|
||
| hyphen_word = pynini.cross(HYPHEN, "हाइफ़न") |
Collaborator
There was a problem hiding this comment.
tsv files for these instead of hardcoding here
mgrafu
reviewed
Jul 9, 2026
| en_to_hi_map = capitalized_input_graph(en_to_hi_map) | ||
| address_keywords_en = pynini.project(en_to_hi_map, "input") | ||
| address_keywords = pynini.union(address_keywords_hi, address_keywords_en) | ||
| english_word_processor = pynutil.add_weight(insert_space + en_to_hi_map, -3.0) |
Collaborator
There was a problem hiding this comment.
is a weight this large necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Implement natural cardinal verbalization for up to 3-digit address numbers.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.