Skip to content

ci: update NVSkills CI request workflow #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willkill07 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

ci: update NVSkills CI request workflow #735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/request-nvskills-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@ name: Request NVSkills CI
on:
issue_comment:
types: [created]
pull_request:
types: [opened, reopened, synchronize, ready_for_review]
push:

jobs:
request:
if: >
github.event_name == 'pull_request' ||
Comment on lines +9 to +16

@coderabbitai coderabbitai Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

ref=053f17aaf44aca0291cf7f62525bb39d581648d6
curl -fsSL \
  "https://raw.githubusercontent.com/NVIDIA/skills/${ref}/.github/workflows/team-request.yml" |
  grep -nE "require-nvskills-ci:|request:|github.event_name == 'pull_request'|github.event_name == 'issue_comment'|github.event_name == 'push'"

Repository: NVIDIA/NeMo-Relay

Length of output: 392

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

caller=".github/workflows/request-nvskills-ci.yml"
ref=053f17aaf44aca0291cf7f62525bb39d581648d6
callee_url="https://raw.githubusercontent.com/NVIDIA/skills/${ref}/.github/workflows/team-request.yml"

printf '%s\n' '--- caller ---'
cat -n "$caller"

printf '%s\n' '--- pinned callee ---'
curl -fsSL "$callee_url" | cat -n

Repository: NVIDIA/NeMo-Relay

Length of output: 11077

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

ref=053f17aaf44aca0291cf7f62525bb39d581648d6
url="https://raw.githubusercontent.com/NVIDIA/skills/${ref}/.github/workflows/require-nvskills-status.yml"

curl -fsSL "$url" | cat -n

Repository: NVIDIA/NeMo-Relay

Length of output: 14080

Route pull_request events to NVSkills CI dispatch

If pull_request events must start validation, update the pinned team-request.yml callee to dispatch for pull_request. The current callee only dispatches for issue_comment and signed push; pull requests enter the required-status job, which fails after the missing-status grace period when no NVSkills status exists. Alternatively, remove the pull_request trigger.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/request-nvskills-ci.yml around lines 9 - 16, Update the
`request` workflow so `pull_request` events are handled consistently: either
configure the pinned `team-request.yml` callee to dispatch NVSkills CI for pull
requests, or remove `pull_request` from the workflow trigger and its
corresponding `request` condition. Ensure no pull request can enter the
required-status path without a matching NVSkills dispatch.

Sources: Path instructions, MCP tools

(github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
startsWith(github.event.comment.body, '/nvskills-ci')) ||
Expand All @@ -20,6 +23,7 @@ jobs:
permissions:
contents: read
pull-requests: read
uses: NVIDIA/skills/.github/workflows/team-request.yml@main
statuses: read
uses: NVIDIA/skills/.github/workflows/team-request.yml@053f17aaf44aca0291cf7f62525bb39d581648d6 # main as of 2026-08-07
secrets:
NVSKILLS_CI_DISPATCH_TOKEN: ${{ secrets.NVSKILLS_CI_DISPATCH_TOKEN }}
Loading