Repository navigation
testing doctest #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grzegorz-k-karch
wants to merge
20
commits into
main
Choose a base branch
from
gkarch/doctest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
testing doctest #2652
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ed136b6
testing doctest
grzegorz-k-karch 5bfab75
added mbridge doc test
grzegorz-k-karch 9876ae8
Clarify README test helpers and harden scenario execution
grzegorz-k-karch a91b791
Refactor README tests to reference named code snippets
grzegorz-k-karch 9023f44
Add advisory CI review for README testability
grzegorz-k-karch 2f88953
Merge branch 'main' into gkarch/doctest
grzegorz-k-karch eb84ce4
Make README testability advice concise
grzegorz-k-karch 52099b4
Run unit CI for README test coverage changes
grzegorz-k-karch b4e7822
Fix README test routing and learning-rate verification
grzegorz-k-karch a106970
Apply suggestion from @coderabbitai[bot]
grzegorz-k-karch 7621ff6
Apply suggestion from @coderabbitai[bot]
grzegorz-k-karch 03160fb
Clarify optional imports in Bridge README fixtures
grzegorz-k-karch 06f2109
Preserve QAT container Torch and FlashAttention versions in CI
grzegorz-k-karch 486049a
Merge branch 'main' into gkarch/doctest
grzegorz-k-karch 68c6649
Add README CLI help checks before example execution
grzegorz-k-karch 6cf7a21
Expose ModelOpt wrapper options in CLI help
grzegorz-k-karch b4b56a4
Reduce README framework self-validation and tests
grzegorz-k-karch f06409e
Separate README advisory workflow from snippet testing
grzegorz-k-karch 1886436
Reuse existing end-to-end tests for README workflows
grzegorz-k-karch 9ca3905
Merge branch 'main' into gkarch/doctest
grzegorz-k-karch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
export PIP_CONSTRAINTapplies only to the current Install dependencies step. The later.github/actions/run-example/action.ymlinstalls the example requirements in a separate step, which therefore receives the container's original emptyPIP_CONSTRAINT. Unlike the TensorRT branch above, the QAT branch never writes this setting to$GITHUB_ENV. Persist the constraint path (or explicitly pass it to the requirements install), so the Torch/FlashAttention compatibility protection covers both installs; verify the imports after the final install.