Skip to content

Add subsystem code ownership - #1343

Closed
jiwenc-nv wants to merge 7 commits into
mainfrom
owners-setup
Closed

jiwenc-nv wants to merge 7 commits into
mainfrom
owners-setup

Conversation

@jiwenc-nv

@jiwenc-nv jiwenc-nv commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Isaac Capture has no automatic subsystem review routing. Add CODEOWNERS with active maintainers and verified repository write access. Core components and examples have dedicated assignments. Documentation shares one owner group, with an exception for EgoPost guides. Plugin infrastructure, integrations, and tests share the union of plugin maintainers. Group related paths together and use repository maintainers as the fallback. Document rule precedence and the separate setting for mandatory approvals.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

  • SKIP=check-copyright-year pre-commit run --all-files passed.
  • Parsed with codeowners==0.9.0: all rules match existing paths; all tracked files have owners; documentation and plugin consolidation, the EgoPost exception, owner replacement, precedence, and fallback checks passed.
  • Verified all nominated accounts have write access.
  • No runtime tests added: ownership configuration and contributor documentation only.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Summary by CodeRabbit

  • Documentation
    • Added code ownership guidance, including how ownership rules assign reviewers and how approval requirements are configured.

Route pull requests to subsystem contributors, keeping related source, tests, examples, and documentation together. Repository maintainers cover unassigned integrations and new paths.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0b84679 and 1b68845.

Files selected for processing: 2
  • .github/CODEOWNERS
  • CONTRIBUTING.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

Adds .github/CODEOWNERS with repository-wide ownership and ordered path-specific assignments for infrastructure, documentation, and feature areas. Updates CONTRIBUTING.md with guidance on owner eligibility, rule ordering, and GitHub review requests. It also states that CODEOWNERS alone does not require owner approval before merge.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Merge Risk: Minimal · up to 1b688

The ownership configuration and contributor guidance present no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Add subsystem code ownership" matches the main change: a new .github/CODEOWNERS file that routes reviews by subsystem, plus a CONTRIBUTING.md section explaining code ownership. It is short,…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Add subsystem code ownership" matches the main change: a new .github/CODEOWNERS file that routes reviews by subsystem, plus a CONTRIBUTING.md section explaining code ownership. It is short, specific, and matches the PR objectives (PR #1343, "Add subsystem code ownership").

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Keep documentation review consistent across all pages and route OpenXR reviews to current maintainers.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Use the union of plugin maintainers for integrations, shared infrastructure, and tests so device-specific overrides do not fragment review coverage.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>

This branch was successfully deployed

1 active deployment
dev — 14b0b1d3 Deployed Oct 25, 2026 by jiwenc-nv via publish-wheel #6026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant