build(python): support Python 3.10 - #391
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
WalkthroughThe project now supports Python 3.10 through 3.14. Package metadata, the PyO3 ABI, tooling targets, workflows, release checks, installation instructions, and documentation drift tests were updated. ChangesPython 3.10 support
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
Signed-off-by: nachiketb <nachiketb@nvidia.com>
bhuvan002
left a comment
There was a problem hiding this comment.
Benchmarking scripts LGTM!
What
Lower the supported Python floor for
nemo-switchyardand its native bindings from 3.12 to 3.10.Why
This makes Switchyard usable by Python 3.10 and 3.11 consumers while retaining one abi3 wheel per platform. Closes #366.
How
requires-pythonand Python tooling targets to 3.10abi3-py310uv.lockValidation
uv run pytest tests/ -v -m "not integration"(134 passed,2 deselected)uv run ruff check .uv run mypy switchyard switchyard_rustcargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacenemo_switchyard-0.2.0-cp310-abi3-manylinux_2_34_x86_64.whlRequires-Python: >=3.10and imports on CPython 3.10 and 3.12Summary by CodeRabbit
New Features
Documentation
Tests