feat(server): advisor route type - #382
Open
eric-liu-nvidia wants to merge 1 commit into
Open
Conversation
This was referenced Aug 12, 2026
eric-liu-nvidia
force-pushed
the
claude/advisor-gate-2-route
branch
2 times, most recently
from
August 12, 2026 21:50
dcba2ee to
010209f
Compare
eric-liu-nvidia
force-pushed
the
claude/advisor-review-gate-rust
branch
from
August 12, 2026 21:50
97ec7bd to
d50e1e7
Compare
Signed-off-by: zengyuanl <zengyuanl@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 2/3 — builds on #371 (core algorithm). Review only this PR's diff; it targets #371's branch.
Adds the
type = "advisor"route to the server TOML config: anAdvisorvariant inRouteConfig, target resolution (executor is the routing/count_tokens target, advisor is judge-only), validation with typed error messages, and 9 config tests.All gate knobs are TOML fields, including the prompts (
reviewer_system_prompt,redo_feedback_prefix) — the built-in strings are just defaults.Stack: #371 (core algorithm) → this PR (server route) → stats projection + e2e.
🤖 Generated with Claude Code