Skip to content

fix: misleading errors when rejecting unsupported optional payloads #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewwhitecdw wants to merge 1 commit into from
Closed

fix: misleading errors when rejecting unsupported optional payloads #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions examples/experimental/litellm/src/switchyard_litellm/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,32 +39,36 @@ def _reject_sequence_payload(
value = request.get(field)
if value is None:
return
if _sequence(value, field):
if (
isinstance(value, Sequence)
and not isinstance(value, (str, bytes, bytearray))
and value
):
raise ValueError(f"{field} is not supported")


def _reject_extensions_payload(request: Mapping[str, object]) -> None:
value = request.get("extensions")
if value is None:
return
extensions = _mapping(value, "extensions")
if set(extensions) - {"fields"}:
if not isinstance(value, Mapping):
raise ValueError("extensions is not supported")
if set(value) - {"fields"}:
raise ValueError("extensions is not supported")
if "fields" in extensions and _mapping(extensions["fields"], "extensions.fields"):
if "fields" in value and value["fields"]:
raise ValueError("extensions is not supported")


def _reject_preservation_payload(request: Mapping[str, object]) -> None:
value = request.get("preservation")
if value is None:
return
preservation = _mapping(value, "preservation")
if set(preservation) - {"requests", "responses"}:
if not isinstance(value, Mapping):
raise ValueError("preservation is not supported")
if set(value) - {"requests", "responses"}:
raise ValueError("preservation is not supported")
for field in ("requests", "responses"):
if field in preservation and _mapping(
preservation[field], f"preservation.{field}"
):
if field in value and value[field]:
raise ValueError("preservation is not supported")


Expand Down