Skip to content

fix(nve-combobox): Endret på fargene som combobox bruker på disabled-tags - #1006

Open
tomapedersen wants to merge 2 commits into
mainfrom
fix/1002_disabled_combobox
Open

tomapedersen wants to merge 2 commits into
mainfrom
fix/1002_disabled_combobox

Conversation

@tomapedersen

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-0c645bd03-1006.westeurope.5.azurestaticapps.net

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The collapsed disabled +N indicator also needs the disabled styling.

Review effort: Lite
Findings: None

What changed in this PR

Updates disabled combobox tag colors and expands documentation for disabled and readonly selections.

Changes:

  • Applies disabled styling to selected tags.
  • Adds preselected-value documentation examples.
File Summary
src/​components/​nve-combobox/​nve-combobox.styles.ts Adds disabled tag styling.
doc-site/​components/​nve-combobox.md Documents disabled and readonly selections.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tomapedersen

tomapedersen commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Jeg har lagt til combobox med preutfylte verdier (multiple og single) for både readonly og disabled på dokumentasjonssiden. Usikker på om de skal være der eller ikke, dersom noen mener de burde fjernes gjør jeg det etter at designer har sett på resultatet

Copilot AI review requested due to automatic review settings September 25, 2026 07:33
@github-actions

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-0c645bd03-1006.westeurope.5.azurestaticapps.net

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Readonly examples present selected values with enabled colors and interactive cursor/markup.

Review effort: Lite
Findings: None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled combobox med verdier har nesten (eller helt) usynlige tags

2 participants