Master dev - LAD Unack notification banner enhancements + package maintenance #376
Merged
Conversation
Treat tokens that are purely numeric or contain non-alphanumeric characters as plain substrings instead of using word-boundary regexes. This updates both the jobSearchSuggestions regex logic and the termMatchers to use includes() for such tokens, avoiding missed matches for values like "14-7570" or "J-00123" and adding clarifying comments.
Introduce a config flag to have the status badge show only active taskings. Job.statusNameAndCount now checks deps.config?.taskingCountActiveOnly?() and, when enabled, counts only taskings whose currentStatus is Tasked, Enroute, or Onsite; otherwise it counts all taskings. ConfigVM: added taskingCountActiveOnly observable (default false), included it in serialization/loading, and auto-saved on change. UI: added a settings switch in tasking.html to toggle the behavior with explanatory text.
Introduce a new boolean rule property `prominent` to visually emphasize urgent alerts. JS: accept and persist `prominent` on rules, toggle alerts--prominent class during in-place updates, set collapsed panel width from 24px to 30px, and mark the 'new-jobs' rule as prominent by default. CSS: add prominent styling and animations in styles/pages/tasking.css (opaque backgrounds, stronger borders, pulse/bounce, enlarged icon and badge) and darkmode overrides in styles/pages/darkmode.css. Minor layout tweak: collapsed alerts button padding/size adjusted to 30px to match the updated collapsed width.
…ansform-runtime, @babel/preset-env, @babel/preset-typescript and babel-loader (#375) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core), [@babel/plugin-transform-react-jsx](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-react-jsx), [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime), [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env), [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) and [babel-loader](https://github.com/babel/babel-loader). These dependencies needed to be updated together. Updates `@babel/core` from 7.22.8 to 8.0.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v8.0.1/packages/babel-core) Updates `@babel/plugin-transform-react-jsx` from 7.22.5 to 8.0.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v8.0.1/packages/babel-plugin-transform-react-jsx) Updates `@babel/plugin-transform-runtime` from 7.22.7 to 8.0.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v8.0.1/packages/babel-plugin-transform-runtime) Updates `@babel/preset-env` from 7.22.7 to 8.0.2 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v8.0.2/packages/babel-preset-env) Updates `@babel/preset-typescript` from 7.22.5 to 8.0.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v8.0.1/packages/babel-preset-typescript) Updates `babel-loader` from 9.1.3 to 10.1.1 - [Release notes](https://github.com/babel/babel-loader/releases) - [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md) - [Commits](babel/babel-loader@v9.1.3...v10.1.1) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 8.0.1 dependency-type: direct:development - dependency-name: "@babel/plugin-transform-react-jsx" dependency-version: 8.0.1 dependency-type: direct:development - dependency-name: "@babel/plugin-transform-runtime" dependency-version: 8.0.1 dependency-type: direct:development - dependency-name: "@babel/preset-env" dependency-version: 8.0.2 dependency-type: direct:development - dependency-name: "@babel/preset-typescript" dependency-version: 8.0.1 dependency-type: direct:development - dependency-name: babel-loader dependency-version: 10.1.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.3 to 0.2.6. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.3...v0.2.6) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) from 7.0.4 to 7.0.5. - [Release notes](https://github.com/yahoo/serialize-javascript/releases) - [Commits](yahoo/serialize-javascript@v7.0.4...v7.0.5) --- updated-dependencies: - dependency-name: serialize-javascript dependency-version: 7.0.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the tasking alerts UI and configuration options. The most significant changes include a new "prominent" alert modifier for visually urgent alerts, enhancements to the job search to handle more flexible queries, and a new configuration option to control how tasking counts are displayed. Additionally, dependencies have been updated and various UI refinements have been made for better usability and appearance.
UI/UX Improvements:
prominentproperty to alert rules, which applies a visually urgent style to alerts (opaque background, heavier border, pulse animation, enlarged icon, and highlighted count badge). The "Unacknowledged incidents" alert now uses this modifier. (src/pages/tasking/components/alerts.js[1] [2] [3];styles/pages/tasking.css[4];styles/pages/darkmode.css[5]styles/pages/tasking.css[1] [2]Job Search Enhancements:
src/pages/tasking/main.js[1] [2]Configuration Options:
taskingCountActiveOnlysetting (with UI toggle) to control whether job status counts include only active taskings (Tasked, Enroute, Onsite) or all taskings. This setting is now saved and loaded with other configuration options. (src/pages/tasking/models/Job.js[1];src/pages/tasking/viewmodels/Config.js[2] [3] [4] [5];static/pages/tasking.html[6]Dependency Updates:
package.jsonpackage.jsonL71-R79)