fix: use public avatars in open-source roster

lib/oss-roster.test.ts

@@ -0,0 +1,26 @@
+import { describe, expect, it, vi } from "vitest";
+import { ossRoster } from "./oss-roster";
+
+vi.mock("@/lib/members", () => ({
+    loadRoster: async () => [{
+        name: "Nishtha Agarwal",
+        github: "nishtha-agarwal-211",
+        usn: "2102508773",
+        hasPhoto: true,
+        councilPosition: "Membership Lead",
+    }],
+    normalizeGithub: (value: string) => value,
+}));
+
+describe("public open-source roster", () => {
+    it("uses a public avatar for a member with a private photo", async () => {
+        const roster = await ossRoster("second-year");
+        const nishtha = roster.find(
+            (member) => member.github === "nishtha-agarwal-211",
+        );
+
+        expect(nishtha?.avatar).toBe(
+            "https://github.com/nishtha-agarwal-211.png",
+        );
+    });
+});

lib/oss-roster.ts

@@ -80,9 +80,7 @@ async function secondYear(): Promise<Contributor[]> {
                 name: member.name,
                 github: member.github,
                 role: member.councilPosition ?? "Member",
-                avatar: member.hasPhoto
-                    ? `/api/members/${member.usn}/avatar`
-                    : `https://github.com/${member.github}.png`,
+                avatar: `https://github.com/${member.github}.png`,
                 year: "second-year",
             });
         }