Repository navigation
feat(chart): pin Edge to v3.7.0 and release chart 0.7.0 - #20
Merged
Merged
Conversation
Pin the Edge release that ships the CronJob, PriorityClass, RBAC and Calico informers (NOFireAI/edge#158), whose read rules this chart already grants (#19). Those kinds stay opt-in through config.kube.resources; the default informer list is unchanged. image.tag is the load-bearing edit: edge-proxy inherits it, so one value pins both deployments. appVersion carries the same v-prefixed string so the tag|default .Chart.AppVersion fallback still resolves. The production example and the standalone manifest are pinned the same way. The version bump publishes the release: the release workflow runs only on a Chart.yaml change and skips a version it has already released. Minor, as the release adds features. Signed-off-by: Panagiotis Moustafellos <pmoust@nofire.ai>
pmoust
force-pushed
the
chore/release-0.7.0
branch
from
October 26, 2026 20:48
17ff234 to
42236f4
Compare
Member
Author
|
@claude-fleet review |
|
Review task queued. Task: d720c833-6dcd-407f-a93d-d20d9f8be754 |
There was a problem hiding this comment.
No findings.
Approve: a four-line version bump, consistent across every place the tree pins a version.
Verified:
- No
v3.6.0string survives anywhere in the tree (grep -rn '3\.6'over yaml/md/sh/tpl/json: clean); the only pins are Chart.yaml:6, values.yaml:12, examples/production-values.yaml:5, manifests.yaml:22. - edge-proxy inherits the tag as the description says:
$tag := .Values.edgeProxy.image.tag | default .Values.image.tag | default .Chart.AppVersion— templates/_helpers.tpl:122, and values.yaml:380 leavesedgeProxy.image.tagcommented out. - manifests.yaml:22 matches
appVersion, which is what tests/manifests/check.sh:38-40 asserts (grep -Fxq "nofireai/edge:$app_version"). version: 0.7.0is what publishes: .github/workflows/release.yml triggers onpaths: ['Chart.yaml']and skips whengh release view nofire-edge-0.7.0succeeds.nofireai/edge:v3.7.0andnofireai/edge-proxy:v3.7.0both exist on Docker Hub as OCI indexes with linux/amd64 + linux/arm64, status active (Docker Hub tags API).- The RBAC rules for the new kinds are already in the chart from #19: templates/rbac.yaml:19,25,28,31 (cronjobs, priorityclasses, clusterrolebindings, Calico ipamconfigs).
- Default informer list untouched — the diff does not touch
config.kube.resources, so the new kinds stay opt-in.
Checks run:
git diff 6352cfa..HEAD— four files, tag/version strings only.grep -rn "3\.6\|3\.7"over the tree excluding node_modules — only the four pins above.
Not run: helm lint, tests/render/run.sh, tests/manifests/check.sh. Neither helm nor yq is installed in this workspace, so the 66-case render suite and the manifests check are unverified here; CI covers them.
Not checked:
- helm lint, tests/render/run.sh and tests/manifests/check.sh were not run — helm and yq are not installed in this workspace
- Whether edge v3.7.0 actually ships the CronJob/PriorityClass/RBAC/Calico informers (NOFireAI/edge#158) — code outside this repository
Task d720c833-6dcd-407f-a93d-d20d9f8be754 on rp2, model claude-opus-5, effort medium.
georgeSkoumas
approved these changes
Oct 27, 2026
asapranidis
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the Edge release that ships the CronJob, PriorityClass, RBAC and Calico informers (NOFireAI/edge#158, released as v3.7.0;
nofireai/edge:v3.7.0andnofireai/edge-proxy:v3.7.0are on Docker Hub for amd64 and arm64). This chart already grants those kinds' read rules (#19).image.tagandappVersionmove tov3.7.0; edge-proxy inherits the tag. The production example and the standalone manifest are pinned the same way.versionmoves to0.7.0, which is what publishes the release: the release workflow runs on aChart.yamlchange and skips a version it already released.config.kube.resources; the default informer list is unchanged.helm lint,tests/render/run.sh(66 passed) andtests/manifests/check.shpass locally.