Skip to content

feat(chart): pin Edge to v3.7.0 and release chart 0.7.0 - #20

Merged
pmoust merged 1 commit into
mainfrom
chore/release-0.7.0
Oct 27, 2026
Merged

pmoust merged 1 commit into
mainfrom
chore/release-0.7.0

Conversation

@pmoust

@pmoust pmoust commented Oct 26, 2026

Copy link
Copy Markdown
Member

Pins the Edge release that ships the CronJob, PriorityClass, RBAC and Calico informers (NOFireAI/edge#158, released as v3.7.0; nofireai/edge:v3.7.0 and nofireai/edge-proxy:v3.7.0 are on Docker Hub for amd64 and arm64). This chart already grants those kinds' read rules (#19).

  • image.tag and appVersion move to v3.7.0; edge-proxy inherits the tag. The production example and the standalone manifest are pinned the same way.
  • version moves to 0.7.0, which is what publishes the release: the release workflow runs on a Chart.yaml change and skips a version it already released.
  • The new kinds stay opt-in through config.kube.resources; the default informer list is unchanged.

helm lint, tests/render/run.sh (66 passed) and tests/manifests/check.sh pass locally.

Pin the Edge release that ships the CronJob, PriorityClass, RBAC and Calico
informers (NOFireAI/edge#158), whose read rules this chart already grants
(#19). Those kinds stay opt-in through config.kube.resources; the default
informer list is unchanged.

image.tag is the load-bearing edit: edge-proxy inherits it, so one value
pins both deployments. appVersion carries the same v-prefixed string so
the tag|default .Chart.AppVersion fallback still resolves. The production
example and the standalone manifest are pinned the same way.

The version bump publishes the release: the release workflow runs only on
a Chart.yaml change and skips a version it has already released. Minor, as
the release adds features.

Signed-off-by: Panagiotis Moustafellos <pmoust@nofire.ai>
@pmoust
pmoust force-pushed the chore/release-0.7.0 branch from 17ff234 to 42236f4 Compare October 26, 2026 20:48
@pmoust

pmoust commented Oct 26, 2026

Copy link
Copy Markdown
Member Author

@claude-fleet review

@claude-fleet

claude-fleet Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review task queued.

Task: d720c833-6dcd-407f-a93d-d20d9f8be754
Commit: 42236f4
Model: claude-opus-5 (effort medium)
Executor: rp2
Status: done. Review posted.

@claude-fleet claude-fleet Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings.

Approve: a four-line version bump, consistent across every place the tree pins a version.

Verified:

  • No v3.6.0 string survives anywhere in the tree (grep -rn '3\.6' over yaml/md/sh/tpl/json: clean); the only pins are Chart.yaml:6, values.yaml:12, examples/production-values.yaml:5, manifests.yaml:22.
  • edge-proxy inherits the tag as the description says: $tag := .Values.edgeProxy.image.tag | default .Values.image.tag | default .Chart.AppVersion — templates/_helpers.tpl:122, and values.yaml:380 leaves edgeProxy.image.tag commented out.
  • manifests.yaml:22 matches appVersion, which is what tests/manifests/check.sh:38-40 asserts (grep -Fxq "nofireai/edge:$app_version").
  • version: 0.7.0 is what publishes: .github/workflows/release.yml triggers on paths: ['Chart.yaml'] and skips when gh release view nofire-edge-0.7.0 succeeds.
  • nofireai/edge:v3.7.0 and nofireai/edge-proxy:v3.7.0 both exist on Docker Hub as OCI indexes with linux/amd64 + linux/arm64, status active (Docker Hub tags API).
  • The RBAC rules for the new kinds are already in the chart from #19: templates/rbac.yaml:19,25,28,31 (cronjobs, priorityclasses, clusterrolebindings, Calico ipamconfigs).
  • Default informer list untouched — the diff does not touch config.kube.resources, so the new kinds stay opt-in.

Checks run:

  • git diff 6352cfa..HEAD — four files, tag/version strings only.
  • grep -rn "3\.6\|3\.7" over the tree excluding node_modules — only the four pins above.

Not run: helm lint, tests/render/run.sh, tests/manifests/check.sh. Neither helm nor yq is installed in this workspace, so the 66-case render suite and the manifests check are unverified here; CI covers them.

Not checked:

  • helm lint, tests/render/run.sh and tests/manifests/check.sh were not run — helm and yq are not installed in this workspace
  • Whether edge v3.7.0 actually ships the CronJob/PriorityClass/RBAC/Calico informers (NOFireAI/edge#158) — code outside this repository

Task d720c833-6dcd-407f-a93d-d20d9f8be754 on rp2, model claude-opus-5, effort medium.

@pmoust
pmoust merged commit 31f1dfe into main Oct 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants