Chore: [AEA-0000] - fix to deploy MTLS#2987
Merged
tstephen-nhs merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
|
wildjames
approved these changes
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the JSON payload construction used by the deploy script when mutual TLS is enabled, so the kid field is correctly included when invoking the Proxygen secret-put Lambda.
Changes:
- Fix jq object syntax in the mTLS secret payload (
kidkey now correctly maps to$kid).
Comments suppressed due to low confidence (1)
.github/scripts/deploy_api.sh:143
eval "cat response.json | jq ..."is unnecessary here and makes the control flow harder to reason about (andevalis best avoided in shell scripts). You can runjq -e '.FunctionError' response.json >/dev/nulldirectly (optionally redirecting stderr), which is simpler and avoidsevalentirely.
if eval "cat response.json | jq -e '.FunctionError' >/dev/null"; then
echo 'Error calling lambda'
| --arg kid "${PROXYGEN_KID}" \ | ||
| --arg proxygenSecretName "${proxygen_private_key_arn}" \ | ||
| '{apiName: $apiName, environment: $environment, secretName: $secretName, secretKey: $secretKey, secretCert: $secretCert, kid, $kid, proxygenSecretName: $proxygenSecretName}' > payload.json | ||
| '{apiName: $apiName, environment: $environment, secretName: $secretName, secretKey: $secretKey, secretCert: $secretCert, kid: $kid, proxygenSecretName: $proxygenSecretName}' > payload.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Correct comma to colon