Skip to content

Bug/refdata connections to instance attributes#98

Merged
stevenhsd merged 3 commits intorelease_v075from
bug/refdata_connections_to_instance_attributes
Apr 29, 2026
Merged

Bug/refdata connections to instance attributes#98
stevenhsd merged 3 commits intorelease_v075from
bug/refdata_connections_to_instance_attributes

Conversation

@stevenhsd
Copy link
Copy Markdown
Contributor

@stevenhsd stevenhsd commented Apr 29, 2026

TLDR of changes

What kind of changes does this PR introduce?

Tick all that apply

  • fix: A bug fix. Correlates with PATCH in SemVer
  • feat: A new feature. Correlates with MINOR in SemVer
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm)
  • ci: Changes to CI configuration files and scripts (example scopes: GitLabCI)

Please check if the PR fulfills these requirements

  • I have read and followed the Contributing guidance
  • Docs have been added / updated
  • Tests and Linting in the CI are passing
  • Changes have been reviewed and approved by a Project Maintainer

Comment thread src/dve/core_engine/backends/implementations/duckdb/reference_data.py Outdated
def load_reference_data(
self,
reference_entity_config: dict[EntityName, ReferenceConfigUnion],
submission_info: Optional[SubmissionInfo],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default?

Comment thread src/dve/core_engine/backends/implementations/spark/reference_data.py Outdated
Comment thread src/dve/pipeline/pipeline.py Outdated
self._processed_files_path = processed_files_path
self._rules_path = rules_path
self._reference_data_loader = reference_data_loader
self._reference_data_loader = None
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed?

Comment thread src/dve/pipeline/pipeline.py Outdated
@georgeRobertson georgeRobertson changed the base branch from main to release_v075 April 29, 2026 09:47
@sonarqubecloud
Copy link
Copy Markdown

@stevenhsd stevenhsd marked this pull request as ready for review April 29, 2026 11:02
@stevenhsd stevenhsd merged commit 32fe565 into release_v075 Apr 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants