Skip to content

Feature/ndit 663 foundry integration #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgeRobertson merged 6 commits into from
Dec 16, 2025

test: reenabled books behave tests

8b787cb
Select commit
Loading
Failed to load commit list.
Merged

Feature/ndit 663 foundry integration #17

test: reenabled books behave tests
8b787cb
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 10, 2025 in 37s

Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 58 in tests/test_pipeline/test_foundry_ddb_pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add replacement fields or use a normal string instead of an f-string. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZsHTAcdeemwQuHmPqf0&open=AZsHTAcdeemwQuHmPqf0&pullRequest=17

Check failure on line 92 in src/dve/pipeline/foundry_ddb_pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "return" statement from this "finally" block. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZsHTAY7eemwQuHmPqfw&open=AZsHTAY7eemwQuHmPqfw&pullRequest=17

Check warning on line 444 in src/dve/pipeline/pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZsHTAb3eemwQuHmPqfy&open=AZsHTAb3eemwQuHmPqfy&pullRequest=17

Check warning on line 60 in tests/test_pipeline/test_foundry_ddb_pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add replacement fields or use a normal string instead of an f-string. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZsHTAcdeemwQuHmPqf1&open=AZsHTAcdeemwQuHmPqf1&pullRequest=17

Check warning on line 341 in src/dve/pipeline/pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZsHTAb3eemwQuHmPqfx&open=AZsHTAb3eemwQuHmPqfx&pullRequest=17

Check warning on line 584 in src/dve/pipeline/pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZsHTAb3eemwQuHmPqfz&open=AZsHTAb3eemwQuHmPqfz&pullRequest=17
View more details on SonarQubeCloud