Skip to content

Commit 0ff64b9

Browse files
committed
fix: remove default connection from ddb json reader
1 parent d10f98f commit 0ff64b9

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

  • src/dve/core_engine/backends/implementations/duckdb/readers

src/dve/core_engine/backends/implementations/duckdb/readers/json.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
from collections.abc import Iterator
55
from typing import Any, Optional
66

7-
from duckdb import DuckDBPyRelation, read_json
7+
import duckdb
8+
from duckdb import DuckDBPyConnection, DuckDBPyRelation
89
from pydantic import BaseModel
910

1011
from dve.core_engine.backends.base.reader import BaseFileReader, read_function
@@ -26,9 +27,11 @@ def __init__(
2627
self,
2728
*,
2829
json_format: Optional[str] = "array",
30+
connection: Optional[DuckDBPyConnection] = None,
2931
**_,
3032
):
3133
self._json_format = json_format
34+
self._connection = duckdb.connect(":memory:") if not connection else connection
3235

3336
super().__init__()
3437

@@ -50,5 +53,5 @@ def read_to_relation( # pylint: disable=unused-argument
5053
}
5154

5255
return self.add_record_index(
53-
read_json(resource, columns=ddb_schema, format=self._json_format) # type: ignore
56+
self._connection.read_json(resource, columns=ddb_schema, format=self._json_format) # type: ignore
5457
)

0 commit comments

Comments
 (0)