Skip to content

Commit d10f98f

Browse files
fix: remove default connection in csv reader causing hanging in multithreaded setups
1 parent 3386b0e commit d10f98f

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

  • src/dve/core_engine/backends/implementations/duckdb/readers

src/dve/core_engine/backends/implementations/duckdb/readers/csv.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
DuckDBPyConnection,
1111
DuckDBPyRelation,
1212
StarExpression,
13-
default_connection,
1413
read_csv,
1514
)
1615
from pydantic import BaseModel
@@ -61,7 +60,7 @@ def __init__(
6160
self.header = header
6261
self.delim = delim
6362
self.quotechar = quotechar
64-
self._connection = connection if connection else default_connection
63+
self._connection = connection if connection else ddb.connect(":memory:")
6564
self.field_check = field_check
6665
self.field_check_error_code = field_check_error_code
6766
self.field_check_error_message = field_check_error_message
@@ -181,7 +180,7 @@ def read_to_relation( # pylint: disable=unused-argument
181180
] + [pl.col(RECORD_INDEX_COLUMN_NAME)]
182181
df = df.select(pl_exprs)
183182

184-
return ddb.sql("SELECT * FROM df")
183+
return self._connection.sql("SELECT * FROM df")
185184

186185

187186
class DuckDBCSVRepeatingHeaderReader(PolarsToDuckDBCSVReader):

0 commit comments

Comments
 (0)