[feature/capgen-v1] Fix three correctness findings from PR #762 review (@jimmielin/claude) - #777
Open
climbfuji wants to merge 2 commits into
Open
Conversation
- suite_resolver: build the backward transform expression from the conflict-resolved temp name, not the raw <name>_l candidate, so a scheme local colliding with the temp no longer silently transforms the wrong variable — including the optional+transform path (case 4), where the pointer already targets the renamed temp. - metadata_table: raise a clear error when a [ccpp-table-properties] block is missing name and/or type (or the key is mistyped), instead of silently dropping the table or failing later with a misleading "variable outside any section" error. - suite_resolver: reject the vertical-flip + allocatable-host combination outright rather than silently dropping the flip and passing vertically-reversed data. Adds 7 unit tests (1557 → 1564).
climbfuji
changed the title
Collaborator
Author
|
@jimmielin Please review and request changes or approve when you get a chance. Thanks! |
Contributor
|
My apologies for the delay, looks good to me, thanks! |
jimmielin
approved these changes
Aug 22, 2026
dustinswales
approved these changes
Aug 24, 2026
dustinswales
left a comment
dustinswales
left a comment
Member
There was a problem hiding this comment.
@jimmielin Thank you for identifying these cases.
Thank you @climbfuji for addressing them.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three correctness findings from PR #762 review (@jimmielin/claude):
User interface changes?: No
Testing:
test removed:
unit tests: added 7 unit tests (1557 → 1564).
system tests:
manual testing: