fix(contract): scope seal_approve authorization to the account owner#371
Merged
Conversation
Require the requested key id to be namespaced to the account owner on both the owner and delegate paths (the owner returns early). This binds `id` to the passed `account`, so a delegate is only ever authorized for the data of the account it is registered on. Adds a regression test asserting a delegate is denied an id scoped to an unrelated owner (aborts ENoAccess). 48/48 tests pass. Code-only change; not deployed.
daniellam258
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
seal_approvenow requires the requested key id to be namespaced to the account owner on both the owner and delegate paths, and returns early for the owner. This bindsidto the passedaccount, so a delegate is only ever authorized for the data of the account it is registered on.Test
Adds a regression test (
test_seal_approve_delegate_rejects_unrelated_id) asserting a delegate is denied an id scoped to an unrelated owner.sui move test→ 48/48 pass (existing owner/delegate/unauthorized cases unchanged).Code-only change; no deploy in this PR.