Test case for re-using problem class - #524
Open
FJanssen-TNO wants to merge 5 commits into
Open
Conversation
FJanssen-TNO
requested review from
KobusVanRooyen and
jimrojerTNO
as code owners
August 10, 2026 15:12
| start_index=10, | ||
| end_index=20, | ||
| ) | ||
| np.testing.assert_allclose( |
Collaborator
There was a problem hiding this comment.
Since the heating demand profile differs for problem 1 and 2, which is also nice because the start and end index is then also applicable. So what about adding a check that problem_1.objective_value != problem_2.objective_value and that the heat demand differs for some timesteps between these 2 problems?
Collaborator
Author
There was a problem hiding this comment.
Added checks that the heat demand is matched, therefore also update the heat demand matching test to take the proper indices and added the check that the objective values of problem 1 and 2 should be different. If the objective values are different than the heat demand is different also different.
Collaborator
|
@FJanssen-TNO review has been completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For specific workflows or cases where the same problem class and ESDL can be used multiple times, example being a rolling horizon optimization. This reduces the time spent in initialising the problem. Timeseries, indexing and many settings can still be updated.