Repository navigation
fix: prevent destructive fallback when opening database files - #17
Merged
Merged
Conversation
MugdhoAI
marked this pull request as ready for review
November 3, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
w+bwhen opening an existing database fails for reasons other than nonexistence.xmode to avoid truncating a file created concurrently.Validation
GitHub Actions will run the full test suite, strict-warning build, benchmark smoke test, and ASan/UBSan suite.
Risk addressed
The previous
r+b→w+bfallback could truncate an existing database after a non-ENOENTopen failure. This change removes that destructive path.