docs: rename info tag protocol_versions -> protocol_version#49
Merged
Conversation
Client and node are compatible only when they run the same protocol
version, so the kind-38385 info tag carries a single value ("1" or "2"),
not a list. Use the singular tag name throughout the transport v2 spec.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… sig - key_management.md: drop the `dm_days` / 30-day mention; the expiration window is a node-internal setting, not part of the protocol. Keep only the NIP-40 reference. - overview.md: clarify that only the inner tuple element 2 is `null`; the outer kind-14 event remains signed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the kind-38385 info-event tag
protocol_versions→protocol_version(singular) throughout the transport v2 spec.Why
A client and a node are compatible only when they run the same protocol version, so the tag advertises a single value (
"1"or"2"), never a list. The plural name was misleading.Coordination
Targets the #48 branch (
docs/transport-v2) so it folds into that PR. Matching code changes:🤖 Generated with Claude Code