Skip to content

docs: rename info tag protocol_versions -> protocol_version#49

Merged
grunch merged 2 commits into
docs/transport-v2from
fix/protocol-version-singular
Jun 17, 2026
Merged

docs: rename info tag protocol_versions -> protocol_version#49
grunch merged 2 commits into
docs/transport-v2from
fix/protocol-version-singular

Conversation

@grunch

@grunch grunch commented Jun 17, 2026

Copy link
Copy Markdown
Member

What

Rename the kind-38385 info-event tag protocol_versionsprotocol_version (singular) throughout the transport v2 spec.

Why

A client and a node are compatible only when they run the same protocol version, so the tag advertises a single value ("1" or "2"), never a list. The plural name was misleading.

Coordination

Targets the #48 branch (docs/transport-v2) so it folds into that PR. Matching code changes:

🤖 Generated with Claude Code

Client and node are compatible only when they run the same protocol
version, so the kind-38385 info tag carries a single value ("1" or "2"),
not a list. Use the singular tag name throughout the transport v2 spec.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a3ee494-fcbd-4701-bb25-bd1e2f0d91b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/protocol-version-singular

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

… sig

- key_management.md: drop the `dm_days` / 30-day mention; the expiration
  window is a node-internal setting, not part of the protocol. Keep only
  the NIP-40 reference.
- overview.md: clarify that only the inner tuple element 2 is `null`; the
  outer kind-14 event remains signed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@grunch grunch merged commit 2d9faa3 into docs/transport-v2 Jun 17, 2026
1 check passed
@grunch grunch deleted the fix/protocol-version-singular branch June 17, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant