Repository navigation
Fix Sheet system bar visibility reads on legacy Android - #70
Merged
Merged
Conversation
Convert native root insets with the owner View so AndroidX accounts for legacy system UI hide flags instead of treating reserved layout space as visible bars on API 23-29. Keep the existing Dialog host and public API. Add a real System UI regression for bottom and floating Sheets. Restrict the existing full owner-isolation test to API 30+, and document legacy focus propagation and the host-side focus workaround in code comments. Validation: debug and Android test APK assembly passed. Four targeted tests passed on Android 10 (API 29), and four passed on Android 12 (API 31). git diff --check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android 6–10 (API 23–29), root window insets can reserve layout space even when system bars are hidden. Convert the native insets with the owner View so AndroidX includes the window's hide flags when a Sheet inherits its opening visibility.
Add one regression that checks actual System UI visibility for bottom and floating Sheets. The existing full owner-isolation test now runs on API 30+: legacy Dialog focus changes can still clear the host's hide flags. This limitation and the host focus workaround are documented in code comments. The Dialog host is unchanged; README is unchanged.
Public API changes: None.
Validation:
git diff --checkpassed.