fix: match only required modifiers for popup hotkey - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ctrl+C+C popup stops working after the global open hotkey is used once.
Cause: the double-copy detector (setup_global_shortcut) mirrors modifier state
from a global rdev listener into ctrl/shift/alt/meta booleans. That mirror can
desync: when the open hotkey fires, a modifier KeyRelease can be missed, so a
modifier stays flagged as held even though it is physically up. This is a state
bug in the tracker, not a physically stuck key.
The detector then required exact modifier equality with the combo, so a
phantom-held Shift/Alt made a real Ctrl+C no longer match, and the popup went
dead until that modifier was pressed and released again (which resyncs it).
Fix: match only the modifiers the combo requires and ignore extras, so phantom
modifier state can no longer block the combo. This restores the behavior from
before the configurable-hotkey refactor.
Repro (before this change):
Verify: