forked from wled/WLED
-
-
Notifications
You must be signed in to change notification settings - Fork 132
Feat: Segment masks #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sayhiben
wants to merge
16
commits into
MoonModules:mdev
Choose a base branch
from
sayhiben:segment-mask
base: mdev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: Segment masks #324
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
dce1ec5
Add segment masks
sayhiben 68f40fc
Mark core files with WLEDMM comments for future maintenance
sayhiben e6a79d1
Mark core files with WLEDMM comments for future maintenance
sayhiben 65a9190
Prefer is2D() over segment maxHeight to support 1D segments in a mixe…
sayhiben 93e4010
Fix reload loops when segment mask file does not exist
sayhiben c4d439d
Apply code style, contribution guidelines
sayhiben 19b2425
Address code review feedback: compiler hints, edge case handling
sayhiben 457c916
Clear segment before enabling mask to avoid stale pixels outside the …
sayhiben fb01e61
Address code review feedback: Replace "do while false" break pattern …
sayhiben ef37320
Revert whitespace-only changes
sayhiben b3b947a
Remove maskInfo from UI
sayhiben 897a1ce
Address automated code review feedback: Clear mask id and invert with…
sayhiben 0cfcebb
Address code review feedback: Guard drawing path from mask functions …
sayhiben 6e997db
Address code review feedback: Avoid potential locking/deadlocks in co…
sayhiben 6389511
Address code review feedback: Always use larger segment mask bitfield
sayhiben 5569781
Address code review feedback: Use DEBUG_PRINTF
sayhiben File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.