Reject failed object block submit results#131
Merged
MoneroOcean merged 1 commit intoMay 19, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
result(including rejection objects such as{status: "FAILED"}) were treated as successful block submissions and caused the pool to skip local slow-hash verification.Description
lib/coins/core/factories.jsby changingacceptDefinedResultto return false for absentrpcResult.resultand to reject result objects that lack ablock_idand whosestatusis not"OK".tests/pool/coin/submitters.jsto cover rejection-shaped results and to verifystatus: "OK"and explicitblock_idcases remain accepted.Reject failed object block submit results.Testing
node --check lib/coins/core/factories.js && node --check tests/pool/coin/submitters.js, which succeeded.npm test -- --test-name-pattern="dero block submit handlers|pool coin helpers: submitters", but it was blocked becauseprotocol-buffers(a dependency required by the test harness) is not installed.npm installto populate dependencies but it failed with a registry403 Forbiddenforcrypto-js, preventing full test execution in this environment.Codex Task