Repository navigation
feat: Added support for connecting to and using the server Entity Systems profiler - #415
Conversation
|
The warning is nice but could we tweak the message to make it a little more "player facing"? We don't really document "ECS version" for players/creators. |
| private _handleRawEvent(event: MessageEvent) { | ||
| if (event.data.type === 'statistic-updated') { | ||
| this._handleEvent(event.data as StatisticUpdatedMessage); | ||
| if (event.data.type === 'statistic-updated-batch' && Array.isArray(event.data.events)) { |
There was a problem hiding this comment.
Is this backwards compatable? I feel like an old MC will fail to work now?
There was a problem hiding this comment.
This event is only used to communicate internally between the minecraft-diagnostics webview and the statistic provider. It did not require any schema change between MC and the Script Debugger.
I did test out the other tabs that rely on StatisticProvider to make sure they still worked fine when connected to both an old and new build.
There was a problem hiding this comment.
Ohhh my mistake yeah ok that is fine then. Cool thanks for the clarification!
AlexDenfordSkyboxLabs
left a comment
AlexDenfordSkyboxLabs
left a comment
There was a problem hiding this comment.
Just one question about backwards compatability
Additional tab added to the diagnostics window
There's now a
Server - Entity Systemstab that connects to the server side ECS profiler. Added atargetto the request arguments for specifying whether they should be directed to the client or server.Moved most of the code that was in
ClientEntitySystemsintoEntitySystemProfiler, so that it can be reused by both client and server tabs. No need to review those changesHere's a video showing it's capabilities (which are effectively the same as the Client variant).
2026-10-30.17-56-39.mp4
Versioning
If the user connects to Minecraft build that doesn't have the server ECS profiling capabilities, this warning box will pop up:
In the opposite case where the Minecraft Debugger is outdated, this message is displayed:
Changes to StatisticUpdatedMessage
Added a batching mechanism for stat message updates.
In cases where there's a lot of stat updates, the extension would become unresponsive due to dealing with a significant queue of
postMessagecalls. We now collect stat updates into a list and process them at a fixed interval to prevent that from happening.