Implement RFC-028 stable schema identity#357
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture
This completes the broad RFC-028 slice without introducing a parallel identity registry. Accepted SchemaIR remains the identity authority, Lance remains the physical substrate, and the manifest remains the sole graph visibility boundary. Identity-less older formats are intentionally refused and upgraded through export/init/load rebuild.
Validation
Greptile Summary
This PR adds stable schema identity across the compiler, manifest, recovery, and runtime paths. The main changes are:
Confidence Score: 4/5
The stable identity paths need fixes before merging.
crates/omnigraph/src/exec/merge.rs; crates/omnigraph-compiler/src/catalog/schema_ir.rs; crates/omnigraph-compiler/src/catalog/schema_shape.rs
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD Source[.pg schema source] --> Shape[SchemaShape] Shape --> IR[SchemaIR v2 stable IDs] IR --> Catalog[Bound catalog] Catalog --> Manifest[Manifest v5 identity rows] Manifest --> Paths[Identity-derived Lance paths] Manifest --> Recovery[Recovery v9 identity pins] Manifest --> Runtime[Diffs, merge, repair, caches] Recovery --> Manifest Runtime --> Manifest%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD Source[.pg schema source] --> Shape[SchemaShape] Shape --> IR[SchemaIR v2 stable IDs] IR --> Catalog[Bound catalog] Catalog --> Manifest[Manifest v5 identity rows] Manifest --> Paths[Identity-derived Lance paths] Manifest --> Recovery[Recovery v9 identity pins] Manifest --> Runtime[Diffs, merge, repair, caches] Recovery --> Manifest Runtime --> ManifestReviews (1): Last reviewed commit: "docs: finalize stable identity contract" | Re-trigger Greptile
Context used: