Align RFC-022–028 architecture and Lance evidence#355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture outcomes
RecoveryRequired; only proven effect-free finalized attempts may reprepareValidation
cargo test --workspace --lockedbash scripts/check-agents-md.shgit diff --checkrustfmt --edition 2024 --check crates/omnigraph/tests/lance_surface_guards.rsGreptile Summary
This PR aligns the architecture docs and RFC set around the current Lance and schema-identity design.
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Comments Outside Diff (1)
docs/rfcs/rfc-023-key-conflict-fencing.mdRenaming the published RFC files without leaving compatibility stubs makes existing branch-relative links to paths like
docs/rfcs/rfc-023-key-conflict-fencing.mdanddocs/rfcs/rfc-026-memwal-streaming-ingest.mdreturn 404 onmain. Because this directory is the durable home for formal decisions, the old filenames should remain as small forwarding stubs or another redirect mechanism should preserve those public paths.Reviews (3): Last reviewed commit: "Merge branch 'main' into codex/rfc022-02..." | Re-trigger Greptile
Context used: