Skip to content

Align RFC-022–028 architecture and Lance evidence#355

Merged
aaltshuler merged 3 commits into
mainfrom
codex/rfc022-028-architecture-alignment
Jul 14, 2026
Merged

Align RFC-022–028 architecture and Lance evidence#355
aaltshuler merged 3 commits into
mainfrom
codex/rfc022-028-architecture-alignment

Conversation

@aaltshuler

@aaltshuler aaltshuler commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • normalize formal RFC filenames into the four-digit namespace and document separate public-contribution and maintainer design-series lifecycles
  • add RFC-028 as the single owner of graph-scoped, rename-stable schema identity and table incarnation, then align RFC-023 through RFC-027 and the architecture ledger around that contract
  • keep Lance MemWAL as the strategic streaming substrate while recording the exact beta.21 public enrollment/admission-seal API blocker
  • add beta.21 surface guards for route-dependent primary-key filters and directional conflict behavior, and update the Lance/testing references
  • add the developer canon and refresh architecture, invariants, governance, and cross-links

Architecture outcomes

  • renames preserve accepted type/property identity and table incarnation; drop/re-add mints a new logical lifetime
  • RFC-024 owns durable head storage, not shared schema identity
  • RFC-025 and RFC-026 carry independent physical ABA tokens rather than importing durable heads as a hidden dependency
  • RFC-026 remains blocked on a public recoverable enrollment receipt or staged transaction plus reversible shard admission APIs; this is an API-shape gate, not an experimental-status judgment on MemWAL
  • partial-effect keyed conflicts retain recovery intent and return RecoveryRequired; only proven effect-free finalized attempts may reprepare

Validation

  • cargo test --workspace --locked
  • bash scripts/check-agents-md.sh
  • git diff --check
  • rustfmt --edition 2024 --check crates/omnigraph/tests/lance_surface_guards.rs

Greptile Summary

This PR aligns the architecture docs and RFC set around the current Lance and schema-identity design.

  • Normalizes formal RFC filenames and lifecycle language.
  • Adds the stable schema identity RFC.
  • Updates architecture, canon, invariants, testing, and Lance references.
  • Adds Lance beta surface guards for primary-key filters and conflict direction.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
crates/omnigraph/tests/lance_surface_guards.rs Adds Lance beta guard coverage for merge-insert primary-key filters and conflict ordering.
docs/rfcs/0028-stable-schema-identity.md Defines graph-scoped schema identity and table incarnation semantics.
docs/rfcs/README.md Documents the four-digit RFC namespace and design-series lifecycle.
docs/dev/canon.md Adds a broad maintainer reference for the system architecture and operating model.

Comments Outside Diff (1)

  1. docs/rfcs/rfc-023-key-conflict-fencing.md

    P2 Deleted RFC Path Breaks Links

    Renaming the published RFC files without leaving compatibility stubs makes existing branch-relative links to paths like docs/rfcs/rfc-023-key-conflict-fencing.md and docs/rfcs/rfc-026-memwal-streaming-ingest.md return 404 on main. Because this directory is the durable home for formal decisions, the old filenames should remain as small forwarding stubs or another redirect mechanism should preserve those public paths.

    Fix in Claude Code

Reviews (3): Last reviewed commit: "Merge branch 'main' into codex/rfc022-02..." | Re-trigger Greptile

Context used:

  • Context used - AGENTS.md (source)
  • Context used - CLAUDE.md (source)

@aaltshuler aaltshuler merged commit 8f2ffe4 into main Jul 14, 2026
7 checks passed
@aaltshuler aaltshuler deleted the codex/rfc022-028-architecture-alignment branch July 14, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant